Fix undertow access_log file name #4670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undertow 1.3.7 changed the default access log file suffix from '.log' to just 'log'. Thus we need to adapt the file name pattern to include the missing dot. Signed-off-by: Sebastian Hoß <mail@shoss.de>
|
The change in undertow was done in undertow-io/undertow@5e655ea |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
wilkinsona
added a commit
that referenced
this pull request
Dec 3, 2015
wilkinsona
added a commit
that referenced
this pull request
Dec 3, 2015
|
Thanks for the PR. I've merged the change into master and added a test so that we'll hopefully notice similar changes in Undertow in the future. |
wilkinsona
added a commit
that referenced
this pull request
Dec 3, 2015
Previously, the test that verified that Undertow's access log could be enabled and was written to the correct file expected the log to be available as soon as the request to the server had completed. Undertow writes the access log asynchronously so the test failed intermittently due to a race between the access log being written and the test asserting that it exists. This commit updates the test to wait for up to 10 seconds for the access log to be available. See gh-4670
|
Great, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undertow 1.3.7 changed the default access log file suffix from '.log' to just 'log'. Thus we need to adapt the file name pattern to include the missing dot.
Otherwise the resulting access log file will be called
access_logloginstead ofaccess_log.log.