DATACMNS-1487 - Dont cache candidate bean definitions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rejected for the reasons described in the ticket. |
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
…projects#342) Avoids ClassNotFoundException when RSA is not on the classpath. Fixes spring-projectsgh-334.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not caching the discovered bean definitions (as the cached discovery is based on base packages of the repository) this fixed DATACMNS-1487 for me.
I consider this a partial PR as this change makes this constructor potentially removable. However, I couldn't get the tests compiling on my clone due to missing querydsl classes and therefore I was unable to refactor the constructor out of the code and tests.
You guys may have a better, more complete fix anyways.