DATACMNS-1591 - @Primary is now considered on repository interfaces #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now elevate the primary annotation from the scanned repository bean definition to the one created for the repository factory. This previously got lost as the former is hidden behind the RepositoryConfiguration interface that previously didn't expose the primary nature of the underlying bean definition. Original pull request: #410.
Whitespace. Original pull request: #410.
odrotbohm
force-pushed
the
issue/DATACMNS-1591
branch
from
c89308c
to
84ec303
Compare
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2019
We now elevate the primary annotation from the scanned repository bean definition to the one created for the repository factory. This previously got lost as the former is hidden behind the RepositoryConfiguration interface that previously didn't expose the primary nature of the underlying bean definition. Original pull request: #410.
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2019
Whitespace. Original pull request: #410.
mp911de
added a commit
that referenced
this pull request
Oct 16, 2019
Add since tags. Reorder methods. Use method references where possible. Original pull request: #410.
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2019
We now elevate the primary annotation from the scanned repository bean definition to the one created for the repository factory. This previously got lost as the former is hidden behind the RepositoryConfiguration interface that previously didn't expose the primary nature of the underlying bean definition. Original pull request: #410.
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2019
Whitespace. Original pull request: #410.
mp911de
added a commit
that referenced
this pull request
Oct 16, 2019
Add since tags. Reorder methods. Use method references where possible. Original pull request: #410.
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now elevate the primary annotation from the scanned repository bean definition to the one created for the repository factory. This previously got lost as the former is hidden behind the RepositoryConfiguration interface that previously didn't expose the primary nature of the underlying bean definition.