added ability to searching deleted entities. Fixed #21. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've recently come across the same issue with deleted entities. It would be great if the pull request from @nikpetrovic could be merged with master. |
|
This fix is not available in version 0.3.0 |
|
Any update on this? |
|
I second the request to merge this! The bug is real. |
|
+1 |
1 similar comment
|
+1 |
|
Should be merged. |
|
+1 |
Related tickets: DATACMNS-891, DATACMNS-960.
|
@nikpetrovic Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
Please fix this! |
|
@nikpetrovic Thank you for signing the Contributor License Agreement! |
|
Hey do the merge please!!... |
|
I have the same issue, please fix this!! Do the merge... |
|
Any reason why this is not merged yet? What's the status on this? Thx. |
|
👍 |
|
👍 |
|
That's merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added flag for searching deleted entities so there is no more exception on querying entities that have RevisionType.DEL. This fixes also #13.