Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exists method to JpaSpecificationExecutor #2388

Closed
StanislauParuchnik opened this issue Dec 17, 2021 · 3 comments
Closed

Add exists method to JpaSpecificationExecutor #2388

StanislauParuchnik opened this issue Dec 17, 2021 · 3 comments
Labels
type: enhancement A general enhancement

Comments

@StanislauParuchnik
Copy link

StanislauParuchnik commented Dec 17, 2021 •
edited

While there is QueryByExampleExecutor.exists(Example<S> example) which under the hood builds Specification from Example to execute exists query, there is no method which accepts Specification object to execute exists query.
Implementation is pretty simple and I can provide a PR
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 17, 2021
@spring-projects spring-projects deleted a comment from quaff Dec 20, 2021
@schauder
Copy link
Contributor

@quaff (Regarding deleted comment) please let maintainers decide on these kind of things. Currently this issue is marked as waiting-for-triage for a reason.

@schauder schauder added the type: enhancement A general enhancement label Jan 24, 2022
@schauder
Copy link
Contributor

I can provide a PR
A PR would be welcome.

@schauder schauder removed the status: waiting-for-triage An issue we've not yet triaged label Jan 24, 2022
@DiegoKrupitza
Copy link
Contributor

DiegoKrupitza commented Feb 21, 2022 •
edited

Can I work on this issue? If yes I opened a PR.

DiegoKrupitza added a commit to DiegoKrupitza/spring-data-jpa that referenced this issue Feb 21, 2022
@DiegoKrupitza
Added exists method with specification to JpaSpecificationExecutor.
e0dff8e 
It is now possible to make existence checks with `Specification`s. This is an addition to checking existence with using an `Example`.

Closes spring-projects#2388
@DiegoKrupitza DiegoKrupitza mentioned this issue Feb 21, 2022
Closed
4 tasks
schauder added a commit that referenced this issue Feb 22, 2022
@schauder
Polishing.
af28245 
Fixed import formatting.
Removed (non-Javadoc) comment, since we don't use them anymore.
Simplified some code and removed superfluous or wrong Javadoc in touched files.
Formatting.

See #2388
Original pull request #2449
schauder pushed a commit that referenced this issue Feb 22, 2022
@DiegoKrupitza @schauder
Added exists method with specification to JpaSpecificationExecutor.
7b3dd77 
It is now possible to make existence checks based on a `Specification`. This is an addition to checking existence with using an `Example`.

Closes #2388
Original pull request #2449
schauder added a commit that referenced this issue Feb 22, 2022
@schauder
Polishing.
47e2423 
Fixed import formatting.
Removed (non-Javadoc) comment, since we don't use them anymore.
Simplified some code and removed superfluous or wrong Javadoc in touched files.
Formatting.

See #2388
Original pull request #2449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added exists method with specification to JpaSpecificationExecutor. DiegoKrupitza/spring-data-jpa
4 participants
@schauder @spring-projects-issues @StanislauParuchnik @DiegoKrupitza