Ignore fields containing Optional.empty when performing Query by Example. #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregturn
force-pushed
the
issue/GH-2176
branch
from
a53b152
to
ff4d0e0
Compare
schauder
requested changes
Jan 11, 2022
|
Will do. |
gregturn
force-pushed
the
issue/GH-2176
branch
from
ff4d0e0
to
a976bca
Compare
The Auditable interface introduces Optional getters, which when combined with Query by Example results in cryptic errors. By ignoring a probe's field that contains an Optional.empty, Query by Example works properly. NOTE: This fix actually tests outside the originally detected scope of Auditable, verifying that ALL Optional.empty() fields are properly handled. Closes #2176.
gregturn
force-pushed
the
issue/GH-2176
branch
from
a976bca
to
9f6ff91
Compare
|
@schauder I've updated this PR with a non-Auditable based test class. |
schauder
pushed a commit
that referenced
this pull request
Feb 4, 2022
The Auditable interface introduces Optional getters, which when combined with Query by Example results in cryptic errors. By ignoring a probe's field that contains an Optional.empty, Query by Example works properly. NOTE: This fix actually tests outside the originally detected scope of Auditable, verifying that ALL Optional.empty() fields are properly handled. Closes #2176 Original pull request #2401
|
Thanks, that's merged. |
schauder
pushed a commit
that referenced
this pull request
Feb 15, 2022
The Auditable interface introduces Optional getters, which when combined with Query by Example results in cryptic errors. By ignoring a probe's field that contains an Optional.empty, Query by Example works properly. NOTE: This fix actually tests outside the originally detected scope of Auditable, verifying that ALL Optional.empty() fields are properly handled. Closes #2176 Original pull request #2401
AntonMolganov
pushed a commit
to AntonMolganov/spring-data-jpa
that referenced
this pull request
Apr 14, 2022
The Auditable interface introduces Optional getters, which when combined with Query by Example results in cryptic errors. By ignoring a probe's field that contains an Optional.empty, Query by Example works properly. NOTE: This fix actually tests outside the originally detected scope of Auditable, verifying that ALL Optional.empty() fields are properly handled. Closes spring-projects#2176 Original pull request spring-projects#2401
AntonMolganov
pushed a commit
to AntonMolganov/spring-data-jpa
that referenced
this pull request
Apr 14, 2022
Removed Given/When/Then comments. They are of limited use, especially since it is debatable what belongs in which section. See spring-projects#2176 Original pull request spring-projects#2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.