DATAJPA-928 - Enabled native query with Pageable. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just removed the check that was actively preventing the use of Pageable. Migrated to tests to AssertJ where applicable.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 19, 2018
Just removed the check that was actively preventing the use of Pageable. Migrated to tests to AssertJ where applicable. Original pull request: #246.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 19, 2018
Just removed the check that was actively preventing the use of Pageable. Migrated to tests to AssertJ where applicable. Original pull request: #246.
|
This looks resolved. |
|
Good job. Only one question. When do you think this change will be available? Thanks in advance. |
|
The referred to ticket lists Kay SR4 and Lovelace M1 as fixed versions, which means it's already shipped. Current Spring Boot 2.0 already contains the fix (as it's on Kay SR5). |
|
Great, Thanks for your reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removed the check that was actively preventing the use of Pageable.
Migrated to tests to AssertJ where applicable.