DATAJPA-1500 - Fix RegEx to support whitespace characters at the end. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the creteCountQueryFor method before, the order by clause did not get removed when having a specific combination of whitespace characters at the end of the input. By removing the $ for matching the end of the line, this is now fixed.
schauder
pushed a commit
that referenced
this pull request
Jun 5, 2019
When using the creteCountQueryFor method before, the order by clause did not get removed when having a specific combination of whitespace characters at the end of the input. By removing the $ for matching the end of the line, this is now fixed. Original pull request: #380.
schauder
added a commit
that referenced
this pull request
Jun 5, 2019
Code formatting. Original pull request: #380.
schauder
pushed a commit
that referenced
this pull request
Jun 5, 2019
When using the creteCountQueryFor method before, the order by clause did not get removed when having a specific combination of whitespace characters at the end of the input. By removing the $ for matching the end of the line, this is now fixed. Original pull request: #380.
schauder
added a commit
that referenced
this pull request
Jun 5, 2019
Code formatting. Original pull request: #380.
schauder
pushed a commit
that referenced
this pull request
Jun 5, 2019
When using the creteCountQueryFor method before, the order by clause did not get removed when having a specific combination of whitespace characters at the end of the input. By removing the $ for matching the end of the line, this is now fixed. Original pull request: #380.
schauder
added a commit
that referenced
this pull request
Jun 5, 2019
Code formatting. Original pull request: #380.
|
Thanks. |
|
Thanks for the fix @florianluediger and @schauder. |
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
When using the creteCountQueryFor method before, the order by clause did not get removed when having a specific combination of whitespace characters at the end of the input. By removing the $ for matching the end of the line, this is now fixed. Original pull request: spring-projects#380.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Code formatting. Original pull request: spring-projects#380.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the creteCountQueryFor method before, the order by clause did not get removed when having a specific combination of whitespace characters at the end of the input.
By removing the $ for matching the end of the line, this is now fixed.
Link to the issue in Jira