Convert nested elements of a raw Document on write. #3887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've only been converting the first level of entries within a Document but missed the inner ones.
TheHett
reviewed
Dec 25, 2021
| Document document = new Document(); | ||
| writeMapInternal((Map<Object, Object>) val, document, ClassTypeInformation.MAP); | ||
| BsonUtils.addToMap(bson, simpleKey, document); | ||
| continue; |
There was a problem hiding this comment.
Perhaps it is better to write everything in the same style: either continue , or if .. else.
christophstrobl
added
the
for: team-attention
|
we closed the related ticket and won't change the current behaviour. |
christophstrobl
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** Draft ***