DATAMONGO-2460 - Fix target type computation for complex id properties with @Field annotation. #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
pushed a commit
that referenced
this pull request
Feb 3, 2020
…s with @field annotation. We now set the target type to org.bson.Document for id properties annotated with @field having the implicit target type derived from the annotation. Along the lines we fixed warn message when an id property with explicit (unsupported) field name is detected. Original pull request: #830.
mp911de
added a commit
that referenced
this pull request
Feb 3, 2020
Reformat code. Use diamond syntax. Original pull request: #830.
mp911de
pushed a commit
that referenced
this pull request
Feb 3, 2020
…s with @field annotation. We now set the target type to org.bson.Document for id properties annotated with @field having the implicit target type derived from the annotation. Along the lines we fixed warn message when an id property with explicit (unsupported) field name is detected. Original pull request: #830.
mp911de
added a commit
that referenced
this pull request
Feb 3, 2020
Reformat code. Use diamond syntax. Original pull request: #830.
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now set the target type to
org.bson.Documentfor id properties annotated with@Fieldhaving the implicit target type derived from the annotation.Along the lines we fixed warning when an id property with explicit (unsupported) field name is detected.