Add support for Range type in derived queries #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional to the two parameter (lower and upper bound) that uses a fixed inclusive pattern it is now possible to provide a `Range` to express inclusive or exclusive bounds explicitly.
|
|
||
| private Filter createLowerBoundFilter(Object value, boolean inclusive) { | ||
| Filter filter = createBoundFilter(Bound.LOWER, value, inclusive); | ||
| filter.setBooleanOperator(booleanOperator); |
There was a problem hiding this comment.
Can we pass on the operator on both of those (lower and upper)?
The "and" is used for the boolean operator between previous and this or this and next?
There was a problem hiding this comment.
The "and" is for "greater/equals than lower bound AND lower/equals than upper bound". The booleanOperator (And/Or) is for the previous ones like findByNameEqualsAnd/OrSomethingBetween.
|
Merged with 5de95cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional to the two parameter (lower and upper bound) that uses a fixed inclusive pattern it is now possible to provide a
Rangeto express inclusive or exclusive bounds explicitly.