DATAREDIS-727 - Fix documentation for RedisCacheManagerBuilder's methods #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
fix_RedisCacheManagerBuilder
branch
from
859f1f3
to
d4a566b
Compare
kezhuw
changed the title
kezhuw
changed the title
mp911de
pushed a commit
that referenced
this pull request
Nov 16, 2017
Document what actually happens. Original pull request: #292.
mp911de
pushed a commit
that referenced
this pull request
Nov 16, 2017
Document what actually happens. Original pull request: #292.
|
Thanks a lot. That's now merged and backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for
RedisCacheManagerBuilder'scacheDefaults,transactionAware,initialCacheNamesandwithInitialCacheConfigurationssays these methods return new instance ofRedisCacheManagerBuilder, but the code just returnsthis.The PR adjusts document to adhere to code.