[DATAREDIS-1062] : Disable select dbIndex in case dbIndex is 0 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shareNativeConnection was set to false and enabled connection pooling before executing each redis command, select dbIndex command was executed. this is un-necessary call. since my application was configured to use single database and i don't want to select a database every time.
|
@tamilselvan-chinnaswamy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
tamilselvan-chinnaswamy
changed the title
|
@tamilselvan-chinnaswamy Thank you for signing the Contributor License Agreement! |
mp911de
pushed a commit
that referenced
this pull request
Nov 22, 2019
When shareNativeConnection was set to false and enabled connection pooling before executing each Redis command, select dbIndex command was executed. Selecting the database can be superfluous when the connection already uses the right database index. Original pull request: #496.
mp911de
added a commit
that referenced
this pull request
Nov 22, 2019
We now select the database on dedicated connection acquisition only if the current database is different from the default database. Database connections are expected to use the default database index when they are acquired so the database index may be changed for the duration when a connection is in use. We also reset dedicated connections to use the default database index on connection cleanup to bring the connection back into its initial state. Add author tag and tests. Original pull request: #496.
mp911de
pushed a commit
that referenced
this pull request
Nov 22, 2019
When shareNativeConnection was set to false and enabled connection pooling before executing each Redis command, select dbIndex command was executed. Selecting the database can be superfluous when the connection already uses the right database index. Original pull request: #496.
mp911de
added a commit
that referenced
this pull request
Nov 22, 2019
We now select the database on dedicated connection acquisition only if the current database is different from the default database. Database connections are expected to use the default database index when they are acquired so the database index may be changed for the duration when a connection is in use. We also reset dedicated connections to use the default database index on connection cleanup to bring the connection back into its initial state. Add author tag and tests. Original pull request: #496.
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.spring.io/browse/DATAREDIS-1062
When shareNativeConnection was set to false and enabled connection pooling before executing each redis command, select dbIndex command was executed. this is un-necessary call. since my application was configured to use single database and i don't want to select a database every time.