Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostgreSQL's JSON[B] #1002

Closed
wants to merge 1 commit into from
Closed

Add support for PostgreSQL's JSON[B] #1002

wants to merge 1 commit into from

Conversation

nkonev
Copy link
Contributor

@nkonev nkonev commented Jul 4, 2021

Resolves #920

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 4, 2021
@nkonev
Copy link
Contributor Author

nkonev commented Jul 14, 2021

@schauder Could you review it ?

@schauder
Copy link
Contributor

We discussed the issue of JSON support internally. We want to give it a more complete treatment that will eventually allow a more powerful usage, like referencing parts of the resulting JSON in queries.

For this we might use your PR, that's why I'd like to keep it open, although we won't merge it as it is right now.

For the issue #920 it would be sufficient to make PGObject a simple type for the Postgres dialect.

@nkonev
Copy link
Contributor Author

nkonev commented Jul 14, 2021

@schauder

For the issue #920 it would be sufficient to make PGObject a simple type for the Postgres dialect.

Ok, than you for reply, I gonna do a small PR with only PGObject

@mp911de
Copy link
Member

mp911de commented Jul 20, 2021

Closing this pull request in favor of a properly designed JSON integration that supports pluggable JSON libraries and dialect-specific support for JSON path queries/projections.

@mp911de mp911de closed this Jul 20, 2021
@mp911de mp911de added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 20, 2021
@mp911de
Copy link
Member

mp911de commented Jul 20, 2021

See also #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PGobject is not considered as simple type
4 participants