Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider PGobject as simple type #1008

Closed
wants to merge 1 commit into from
Closed

Consider PGobject as simple type #1008

wants to merge 1 commit into from

Conversation

nkonev
Copy link
Contributor

@nkonev nkonev commented Jul 15, 2021

As discussed here #1002

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 15, 2021
@nkonev nkonev requested a review from mp911de July 15, 2021 08:09
@mp911de
Copy link
Member

mp911de commented Jul 15, 2021

Thanks a lot. Care to provide a test that verifies that PGobject is considered a simple type? Ideally, as an integration test. If you encounter any roadblocks, we're happy to take this PR from here.

@nkonev
Copy link
Contributor Author

nkonev commented Jul 15, 2021 •
edited

Thanks a lot. Care to provide a test that verifies that PGobject is considered a simple type? Ideally, as an integration test. If you encounter any roadblocks, we're happy to take this PR from here.

@mp911de I have done the test which ensures that there isn't warning with OutputCaptureExtension

@nkonev
Copy link
Contributor Author

nkonev commented Jul 19, 2021

@mp911de Could you review integration test ?

@mp911de mp911de self-assigned this Jul 20, 2021
@mp911de mp911de changed the title Add initial support for PGObject Consider PGobject as simple type Jul 20, 2021
mp911de pushed a commit that referenced this pull request Jul 20, 2021
@nkonev @mp911de
Consider PGobject as simple type.
d1e8e72 
Closes #920
Original pull request: #1008.
mp911de added a commit that referenced this pull request Jul 20, 2021
@mp911de
Polishing.
f997a61 
Remove Jackson in favor of JsonHolder and PGobject usage within the domain model. Convert spaces to tabs. Reorder methods and classes.

See #920
Original pull request: #1008.
@mp911de mp911de added the type: enhancement A general enhancement label Jul 20, 2021
@mp911de mp911de added this to the 2.3 M2 (2021.1.0) milestone Jul 20, 2021
@mp911de
Copy link
Member

mp911de commented Jul 20, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Jul 20, 2021
@mp911de mp911de mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Milestone
2.3 M2 (2021.1.0)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkonev @mp911de @spring-projects-issues