DATAJDBC-551 - Supports derived delete. #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lseeker
force-pushed
the
issue/DATAJDBC-551
branch
from
8743811
to
31c75cb
Compare
lseeker
force-pushed
the
issue/DATAJDBC-551
branch
from
31c75cb
to
d4f0781
Compare
schauder
requested changes
Nov 10, 2020
There was a problem hiding this comment.
This looks pretty good and thanks for rebasing it on the current master.
In order to merge this we need a proper set of unit tests ensuring the right kind of SQL in generated.
The following cases should be covered:
- deleting an aggregate with at least two level reference, i.e.
root->child->grandchild - similar as above, but with one level replaced by an embedded entity.
- deleting an aggregate by a direct attribute
- deleting an aggregate by an indirect attribute
spring-projects-issues
added
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
|
Hello! Any progress on this issue? |
lseeker
force-pushed
the
issue/DATAJDBC-551
branch
from
d4f0781
to
c419220
Compare
schauder
added
type: enhancement
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
We support Oracle's experimental R2DBC driver by providing a dialect including bind markers. Since the driver is not yet available from Maven Central and it requires module-path support for ServiceLoader discovery, we need to apply a few workarounds including absence check for our integration tests. See #230
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Make count assertions case-insensitive regarding the count column name. Add missing license headers. Support DatabaseContainer without a database name. See #230
nkonev
pushed a commit
to nkonev/spring-data-jdbc-many-to-many
that referenced
this pull request
Apr 6, 2022
|
I'm surprised that this feature has not yet been implemented, even though the documentation says it is supported with examples. Is there any progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DATAJDBC-551, delete relations by subquery.
JdbcDeleteQueryCreator creates stream chain of delete queries, and executed by modifying query executor.