Patch with object value omitted [DATAREST-885]

[spring-projects-issues]

Mathias D opened DATAREST-885 and commented

After migrating to spring data rest 2.5.2 the PATCH operation with application/json-patch+json for object values is broken.

Consider the following entity:

@Entity
public class Product implements Identifiable<Long> {

    @Id
    @GeneratedValue(strategy = IDENTITY)
    private Long id;

    private String name;

    @Embedded
    private Gtin gtin;
}

@Embeddable
@Getter
@Setter
public class Gtin {

    private String type;
    private String value;
}

I try to patch with the following payload.

[
  {
    "op":"replace",
    "path":"/gtin",
    "value":{"type":"EAN","value":"some"}
  }
]

As a result of this operation the property to update (gtin) is null.

org.springframework.data.rest.webmvc.json.patch.JsonLateObjectEvaluator#evaluate returns null because it receives a JsonMappingException as it tries to serialize the value json into the entity type.

Please see this product to reproduce the issue https://github.com/mduesterhoeft/spring-data-rest-json-patch-issue

---

Affects: 2.5.2 (Hopper SR2)

Reference URL: https://github.com/mduesterhoeft/spring-data-rest-json-patch-issue

Referenced from: pull request #223

Backported to: 2.5.3 (Hopper SR3)

1 votes, 1 watchers