Class-Level Request Mapping on Controller and Custom POST Breaks GETs [DATAREST-1265]

[spring-projects-issues]

Mike Whittemore opened DATAREST-1265 and commented

If I have a UserRepository and then create a custom controller endpoint for handling resource creation, e.g.

@RepositoryRestController
@RequestMapping("/users")
class UserController {
    ...
    @PostMapping
    public ResponseEntity<?> create(...) {...}
}

requests like GET /users stop working with the response:

{{ "timestamp": "2018-07-25T01:45:15.780+0000", "status": 405, "error": "Method Not Allowed", "message": "Request method 'GET' not supported", "path": "/users"}

If I move the request mapping from the class to the method (and if there are multiple endpoints/paths, to every one) everything works as expected:

@RepositoryRestController
class UserController {
    ...
    @PostMapping("/users")
    public ResponseEntity<?> create(...) {...}
} 

This seems like a bug to me, since it is inconsistent with WebMVC behavior and I only discovered the "fix" via "voodoo" programming

---

No further details from DATAREST-1265

[spring-projects-issues]

Oliver Drotbohm commented

That's an unfortunate side effect of Spring MVC insisting to handle controllers with a class level @RequestMapping in it's default HandlerMapping implementation. Spring Data REST uses a custom one and has to rely on users not using a class-level @RequestMapping. I'll turn this ticket into a documentation one, so that this gets more obvious. /cc rstoyanchev

[spring-projects-issues]

Rossen Stoyanchev commented

The main case is interface-based proxies as far as I know. The interface would have the @RequestMapping but not the @Controller annotation, so we would miss it otherwise. juergen.hoeller, perhaps we can refine this, and use @RequestMapping alone, i.e. without @Conntroller, only if it is coming from an interface?

[odrotbohm]

Duplicates #1342. See the my latest comment over there.