Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augmenting arrays during merge patch only appends one element #2357

Closed
odrotbohm opened this issue Jan 19, 2024 · 0 comments
Closed

Augmenting arrays during merge patch only appends one element #2357

odrotbohm opened this issue Jan 19, 2024 · 0 comments
Assignees
@odrotbohm
Labels
type: bug A general bug
Milestone
4.1.9 (2023.0.9)

Comments

@odrotbohm
Copy link
Member

odrotbohm commented Jan 19, 2024 •
edited
Loading

Originally reported here. Reproducer here.

Pretty simple (read: stupid) bug. We are using break inside a loop instead of a continue. That's why we only append one element.
@odrotbohm odrotbohm added the type: bug A general bug label Jan 19, 2024
@odrotbohm odrotbohm added this to the 4.3 M1 (2024.0.0) milestone Jan 19, 2024
@odrotbohm odrotbohm self-assigned this Jan 19, 2024
This was referenced Jan 19, 2024
Closed
Closed
odrotbohm added a commit that referenced this issue Jan 19, 2024
@odrotbohm
Properly append all superfluous elements to an array during merge patch.
cebd491 
Fixes GH-2357.
odrotbohm added a commit that referenced this issue Jan 19, 2024
@odrotbohm
Properly append all superfluous elements to an array during merge patch.
9ab41e7 
Fixes GH-2357.
@odrotbohm odrotbohm mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: bug A general bug
Projects
None yet
Milestone
4.1.9 (2023.0.9)
Development

No branches or pull requests
1 participant
@odrotbohm