Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAREST-524 Invoke validators registered with composite bean names #2048

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DATAREST-524 Invoke validators registered with composite bean names #2048

wants to merge 1 commit into from

Conversation

laskaridis
Copy link

@laskaridis laskaridis commented Jul 28, 2021

The ValidatingRespositoryEventListener will currently ignore any
validator that has been registered under a composite key consisting of
the event name post-fixed by the model name and the keyword "Validator".
This does not allow executing validator beans registered using the
"@component" or "@bean" annotations, which should be possible according
to the reference guide.

This happens because the code will only look for validators registered
using the event name as a key only. To fix this, I added a second lookup
(if the previous fails) by a composite key name that follows the
semantics described previously.

See: https://docs.spring.io/spring-data/rest/docs/3.5.3/reference/html/#validation

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

The ValidatingRespositoryEventListener will currently ignore any
validator that has been registered under a composite key consisting of
the event name post-fixed by the model name and the keyword "Validator".
This does not allow executing validator beans registered using the
"@component" or "@bean" annotations, which should be possible according
to the reference guide.

This happens because the code will only look for validators registered
using the event name as a key only. To fix this, I added a second lookup
(if the previous fails) by a composite key name that follows the
semantics described previously.

See: https://docs.spring.io/spring-data/rest/docs/3.5.3/reference/html/#validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants