Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect return type of Kotlin suspending functions [SPR-16515] #21058

Closed
spring-projects-issues opened this issue Feb 19, 2018 · 2 comments
Closed

Incorrect return type of Kotlin suspending functions [SPR-16515] #21058

spring-projects-issues opened this issue Feb 19, 2018 · 2 comments
Assignees
@sdeleuze
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2 M1

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Feb 19, 2018 •
edited

Konrad Kamiński opened SPR-16515 and commented

The return type of Kotlin suspending functions (as returned via getParameterType() and getGenericParameterType() methods of MethodParameter) is incorrect. The true return type is actually a generic type of the last parameter of the method.

This issue affects spring-kotlin-coroutine library, specifically issues #10 and #14.

This issue is related to #19975.

Affects: 5.0.3

Issue Links:

Referenced from: pull request #1694

2 votes, 6 watchers
@spring-projects-issues
Copy link
Collaborator Author

Sébastien Deleuze commented

See this PR comment.

@spring-projects-issues
Copy link
Collaborator Author

Sébastien Deleuze commented

Since we have not been able to progress on the question raised on the PR, and given the fact I would like to propose supporting Coroutines for 5.2, I think it is better to target 5.2 as well for that one.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.2 RC1 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Feb 18, 2019
@sdeleuze
Add Coroutines support for WebClient and WebFlux.fn
19f792d 
This commit is the first part of a more complete Coroutines
support coming in Spring Framework 5.2. It introduces suspendable
Kotlin extensions for Mono based methods in WebFlux classes like
WebClient, ServerRequest, ServerResponse as well as a Coroutines
router usable via `coRouter { }`.

Coroutines extensions use `await` prefix or `AndAwait` suffix,
and most are using names close to their Reactive counterparts,
except `exchange` in `WebClient.RequestHeadersSpec`
which translates to `awaitResponse`.

Upcoming expected changes are:
 - Leverage `Dispatchers.Unconfined` (Kotlin/kotlinx.coroutines#972)
 - Expose extensions for `Flux` based API (Kotlin/kotlinx.coroutines#254)
 - Introduce interop with `CoroutineContext` (Kotlin/kotlinx.coroutines#284)
 - Support Coroutines in `ReactiveAdapterRegistry`
 - Support Coroutines for WebFlux annotated controllers
 - Fix return type of Kotlin suspending functions (spring-projectsgh-21058)

See spring-projectsgh-19975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
2 participants
@sdeleuze @spring-projects-issues