Javadoc missing on some public BeanDefinitionParserDelegate methods #23349
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
status: backported
An issue that has been backported to maintenance branches
type: enhancement
A general enhancement
Milestone
Affects: \2.5.1 (also master)
I have inherited some code and was doing some maintenance inside. This code called
BeanDefinitionParserDelegate#parseCustomElement(Element)
and now also callsBeanDefinitionParserDelegate#parseCustomElement(Element, BeanDefinition)
.I noted that these methods have no javadoc and this engendered a question "How mainstream is this/are we doing the right thing". Having eyeballed the (Spring) code I'm reasonably sure that this the right thing and whilst I'd imagine that custom parsers are not mainstream I'm comfortable with the code.
But can we add some javadoc? I'll try and pull together a PR if it would help. but I note that there are other methods in this class which are missing javadoc and I'd not be comfortable adding it to them.
Thanks
/Rod
The text was updated successfully, but these errors were encountered: