Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade spring-r2dbc's test dependency on the H2 database to 2.0.x #27902

Closed
sbrannen opened this issue Jan 7, 2022 · 4 comments
Closed

Upgrade spring-r2dbc's test dependency on the H2 database to 2.0.x #27902

sbrannen opened this issue Jan 7, 2022 · 4 comments
Assignees
@sbrannen
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: task A general task

Comments

@sbrannen
Copy link
Member

sbrannen commented Jan 7, 2022 •
edited
Loading

This is a follow up to #27870, since we cannot upgrade spring-r2dbc's test dependency to H2 2.0 until r2dbc/r2dbc-h2#204 is released.
@sbrannen sbrannen self-assigned this Jan 7, 2022
@sbrannen sbrannen added the type: dependency-upgrade A dependency upgrade label Jan 7, 2022
@sbrannen sbrannen added this to the 6.0.0-M3 milestone Jan 7, 2022
@sbrannen sbrannen mentioned this issue Jan 7, 2022
Closed
@snicoll snicoll changed the title Upgrade to H2 database 2.0 Add support for H2 2.x Jan 7, 2022
@snicoll snicoll added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels Jan 7, 2022
@sbrannen sbrannen changed the title Add support for H2 2.x Upgrade to H2 database 2.0.x Jan 7, 2022
@sbrannen sbrannen added type: dependency-upgrade A dependency upgrade and removed type: enhancement A general enhancement labels Jan 7, 2022
@sbrannen sbrannen changed the title Upgrade to H2 database 2.0.x Upgrade spring-r2dbc's test dependency on the H2 database to 2.0.x Jan 7, 2022
@sbrannen sbrannen added type: task A general task and removed type: dependency-upgrade A dependency upgrade labels Jan 7, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jan 7, 2022
@sbrannen
Partially upgrade to H2 database 2.0.206
54bdab4 
Commit ed4e228 introduced support for H2 2.0.x but did not upgrade
the H2 dependency.

This commit upgrades the H2 dependency to version 2.0.206 but also
adds an explicit test dependency on version 1.4.200 in spring-r2dbc,
since r2dbc-h2 does not yet support H2 2.0.x.

Once r2dbc/r2dbc-h2#204 has been included in a
released version of r2dbc-h2 we will be able to upgrade spring-r2dbc's
test dependency on the H2 database to 2.0.x as well.

See spring-projectsgh-27870
See spring-projectsgh-27902
@sbrannen sbrannen added the status: blocked An issue that's blocked on an external project change label Jan 7, 2022
@DrZ7
Copy link

DrZ7 commented Jan 13, 2022

r2dbc-h2:0.9.0.RELEASE?

@sbrannen
Copy link
Member Author

r2dbc-h2:0.9.0.RELEASE?

Probably so, but we are likely waiting for the next umbrella GA release for R2DBC: https://github.com/r2dbc/r2dbc-bom/milestone/17

@sbrannen
Copy link
Member Author

sbrannen commented Jan 13, 2022 •
edited
Loading

Update:

As far as I understand, r2dbc-h2 0.8 will continue to only support H2 1.4.x; whereas, r2dbc-h2 0.9 will support H2 2.0.x.

Release Notes have been updated:

@sbrannen sbrannen mentioned this issue Jan 25, 2022
Closed
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) and removed status: blocked An issue that's blocked on an external project change labels Feb 4, 2022
@sbrannen
Copy link
Member Author

sbrannen commented Feb 5, 2022

Superseded by #27976 and actually already addressed in main in e5af4aa.

Thanks, @jhoeller

@sbrannen sbrannen closed this as completed Feb 5, 2022
@sbrannen sbrannen removed this from the 6.0.0-M3 milestone Feb 5, 2022
@sbrannen sbrannen added the status: superseded An issue that has been superseded by another label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbrannen @snicoll @jhoeller @DrZ7