SPR-14754 - Add EnableWebReactive + WebReactiveConfigurer #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the existing web reactive configuration infrastructure with the following changes: * renamed `WebReactiveConfiguration` to `WebReactiveConfigurationSupport` and is is no longer a Configuration class * created the `WebReactiveConfigurer` interface; Configuration classes implementing it will augment the web reactive configuration support * created the `DelegatingWebReactiveConfiguration` and `WebReactiveConfigurerComposite` to effectively tie those custom-defined configurers to the main configuration support * created the `@EnableWebReactive` to active that support in configuration classes Issue: SPR-14754
bclozel
changed the title
|
Hey @sdeleuze @rstoyanchev @poutsma I've got a draft PR for improving our configuration infrastructure for web reactive. Nothing ground-breaking here, since it pretty much mirrors what we have on the MVC side. I've made one significant change: I've dropped the |
rstoyanchev
added a commit
that referenced
this pull request
Oct 14, 2016
|
@bclozel, I've merged the PR. I made some improvements in the WebReactiveConfigurerComposite to streamline the delegation to WebReactiveConfigurer to pre-create custom bean instances. And also applied some polish. Thanks! |
|
nice.. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the existing web reactive configuration
infrastructure with the following changes:
WebReactiveConfigurationtoWebReactiveConfigurationSupportand is is no longer a Configurationclass
WebReactiveConfigurerinterface; Configuration classesimplementing it will augment the web reactive configuration support
DelegatingWebReactiveConfigurationandWebReactiveConfigurerCompositeto effectively tie those custom-definedconfigurers to the main configuration support
@EnableWebReactiveto active that support inconfiguration classes
Issue: SPR-14754