Support instantiating Kotlin classes with optional parameters #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoeller
reviewed
Jul 19, 2017
| } | ||
| catch (NoSuchMethodException ex) { | ||
| throw new BeanInstantiationException(clazz, "No default constructor found", ex); | ||
| Constructor<T> ctor = findPrimaryConstructor(clazz); |
There was a problem hiding this comment.
I guess we'll have to differentiate here: For instantiateClass(Class), we can only deal with the no-arg default constructor (public or non-public) in the regular Java case... not with a non-default unique public constructor that findPrimaryConstructor might return to us.
So maybe we'll do some straight KotlinDelegate.findPrimaryConstructor vs clazz.getDeclaredConstructor() right here in instantiateClass(Class), and only use the public findPrimaryConstructor variant for data binding purposes.
There was a problem hiding this comment.
Indeed I am going to change that accordingly to your proposal.
sdeleuze
force-pushed
the
SPR-15673
branch
2 times, most recently
from
86431a5
to
2e2c2ec
Compare
This commit updates BeanUtils class in order to add Kotlin optional parameters with default values support to the immutable data classes support introduced by SPR-15199. Issue: SPR-15673
|
Merged via fa4d139. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates BeanUtils class in order to add Kotlin optional
parameters with default values support to the immutable data classes
support introduced by SPR-15199.
@jhoeller Could you please review and hopefully merge it with your changes if any?
Issue: SPR-15673