Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ContextLoaderUtils class, these two methods contain similar loop logic
Created a private method that returns a list of ContextConfigurationAttribute, and changed above two methods to use the new one to clean up the duplicated logic.
Further cleanup suggestion:
"resolveContextConfigurationAttributes(Class<?> clazz)" method returns "List< ContextConfigurationAttributes>", and the returned list has parent-class-first order.
On the other hand, the caller of the method, "buildMergedContextConfiguration(...)", uses the list in reverse order: child class first.
So, it would be easier to read if "resolveContextConfigurationAttributes" method returns the list as child-first order.
This method has unit tests in ContextLoaderUtilsTests, so they need to be updated as well.
Issue: SPR-9918
I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.