Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDBC SqlValue classes for arrays #1850

Closed
wants to merge 1 commit into from
Closed

Add JDBC SqlValue classes for arrays #1850

wants to merge 1 commit into from

Conversation

marschall
Copy link
Contributor

Introduce two SqlValue classes for more convenient use of arrays from
Spring JDBC.

  • AbstractSqlArrayValue abstract base class for array values
  • SqlArrayValue concrete implementation class that uses JDBC 4.0 to
    create an array

Issue: SPR-16904

@marschall
SPR-16904 Add JDBC SqlValue classes for arrays
4481ded 
Introduce two SqlValue classes for more convenient use of arrays from
Spring JDBC.

- AbstractSqlArrayValue abstract base class for array values
- SqlArrayValue concrete implementation class that uses JDBC 4.0 to
  create an array

Issue: SPR-16904
@snicoll snicoll changed the title SPR-16904 Add JDBC SqlValue classes for arrays SPR-16904 - Add JDBC SqlValue classes for arrays Jun 12, 2018
@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@rstoyanchev rstoyanchev added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Nov 10, 2021
@bclozel bclozel added this to the 6.x Backlog milestone Dec 21, 2021
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 21, 2021
@bclozel bclozel changed the title SPR-16904 - Add JDBC SqlValue classes for arrays Add JDBC SqlValue classes for arrays Dec 21, 2021
@jhoeller
Copy link
Contributor

I'm bringing this into 6.1 as a single streamlined SqlArrayValue class based on JDBC 4, also serving as a template for custom SqlValue implementations (since we only provide internal implementations within Jdbc4SqlXmlHandler up until this point).

Thanks for the PR in any case, after all those years! I've reused your tests and credited your as a co-author.

@jhoeller jhoeller self-assigned this Jul 12, 2023
@jhoeller jhoeller modified the milestones: 6.x Backlog, 6.1.0-M2 Jul 12, 2023
@jhoeller jhoeller closed this in 3fed2ec Jul 12, 2023
jhoeller added a commit that referenced this pull request Jul 12, 2023
@jhoeller
Use varargs for array elements
094eb3e 
See gh-1850
@marschall
Copy link
Contributor Author

Thanks a lot, looking forward to the 6.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marschall @jhoeller @bclozel @rstoyanchev @spring-projects-issues