Support wildcards in @PropertySource #24591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inardz Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@inardz Thank you for signing the Contributor License Agreement! |
sbrannen
changed the title
sbrannen
added
in: core
sbrannen
reviewed
Jun 9, 2020
| /** | ||
| * Parse locations and expand those with wildcard | ||
| */ | ||
| private String[] getWildcardLocations(String[] locations) throws IOException { |
There was a problem hiding this comment.
If we were to introduce support for wildcards, we would need to use PathMatchingResourcePatternResolver instead of implementing a custom method like you have done here.
|
Thanks for the PR! After further consideration, the team has decided to close this PR and investigate options for implementing the support requested in #21325, which is currently slated for 5.3 M2 and labeled as "pending design work". |
sbrannen
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21325