-
Notifications
You must be signed in to change notification settings - Fork 37.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented issue #25553(Optimize single character equality checks) #25570
implemented issue #25553(Optimize single character equality checks) #25570
Conversation
@abhishek-abhi thanks for the PR. Please don't mention individual team member, the team already receives a notification when the PR is created. |
Thanks for the PR. We are happy to see that you are eager to contribute. Please note that you actually implemented changes for #25552 and not for #25553. In addition, both of those issues have descriptions stating "Investigate claims made in Micro optimizations in Java. String.equals() article." That means that the issues are there as placeholders for the core team to investigate. If the core team wishes for someone from the community to pick up an issue, we add the If you don't see the In addition, some of the changes in this PR are breaking changes that would result in a Regarding the tests, if we go to the trouble of updating tests like that we would typically rather refactor the assertions to make use of dedicated AssertJ functionality that better suits the purpose. In light of the above, I am closing this PR, and the team will investigate #25552 and #25553 in the 5.3 RC1 time frame. |
For future reference, please make sure that you run a full build locally before submitting any PR. This PR actually fails the build due to a compilation error:
If that error is fixed, there are still 3 additional compilation errors:
|
I will fix these and reopen the PR |
There is no need to do that. I have added the |
Okay. Can you please assign this to myself if possible. I would love to work on this issue. |
No description provided.