-
Notifications
You must be signed in to change notification settings - Fork 37.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes and improvements to the reference documentation #29694
Closed
simonbasle
wants to merge
10
commits into
spring-projects:main
from
simonbasle:refguide/obviousFixes
Closed
Small fixes and improvements to the reference documentation #29694
simonbasle
wants to merge
10
commits into
spring-projects:main
from
simonbasle:refguide/obviousFixes
Commits on Dec 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8400150 - Browse repository at this point
Copy the full SHA 8400150View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bcc1f3 - Browse repository at this point
Copy the full SHA 4bcc1f3View commit details -
Rework linking to Sprinv MVC Async support vs WebFlux section
The link would be named "Compared to WebFlux", which is easy to mix up with the various links to equivalent sections in the WebFlux chapter. Here the links point to a small section comparing the Servlet Async API to the WebFlux stack from a high perspective. In this commit we eliminate most of these links, except at the beginning of the Asynchronous section. We also add a small mention of the Servlet configuration in the comparison paragraphs, as Configuring section is the one furthest from the comparison paragraphs that used to have a link to it.
Configuration menu - View commit details
-
Copy full SHA for 355bade - Browse repository at this point
Copy the full SHA 355badeView commit details -
Fix subsection style in WebFlux Concurrency Model
The block title style previously used was not rendered in HTML and the title wouldn't be differentiated from the text. It was in the PDF, as italics. Introducing delimited blocks in the open (`--`) style did introduce styling, but the vertical alignment isn't great. This commit turns these block titles to actual (deep) section titles. In the final HTML, at this depth there is no numbering but bold styling is there. The PDF rendering has also be verified to have relevant style.
Configuration menu - View commit details
-
Copy full SHA for c878044 - Browse repository at this point
Copy the full SHA c878044View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cfcd21 - Browse repository at this point
Copy the full SHA 6cfcd21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 627a7ab - Browse repository at this point
Copy the full SHA 627a7abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 068f188 - Browse repository at this point
Copy the full SHA 068f188View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6344f1 - Browse repository at this point
Copy the full SHA f6344f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d474f06 - Browse repository at this point
Copy the full SHA d474f06View commit details
Commits on Dec 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 84bab71 - Browse repository at this point
Copy the full SHA 84bab71View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.