Added Java 7 instrumentation manifest attributes #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading to OpenJDK 7 I can't retransform classes using
InstrumentationSavingAgent.getInstrumentation().addTransformer(t, true);
After some research I feel that spring-instrument is missing the required manifest attributes for Java 7 (see http://docs.oracle.com/javase/7/docs/api/java/lang/instrument/package-summary.html)
I'm neither an expert for instrumentation nor Gradle but I thought I'd give it a shot to at least start a discussion.
|
Thanks for the pull request. Could you please also raise a JIRA for this issue as that is generally our preferred system for tracking bugs. |
|
btw, there is also an unneeded dependency on spring-core. I've created molindo-instrument as a temporary workaround for this issue where you can easily verify this. Do I have to create another pull request and JIRA issue for that? |
|
Thanks. Yes please to the second JIRA. |
|
see #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to OpenJDK 7 I can't retransform classes using
InstrumentationSavingAgent.getInstrumentation().addTransformer(t, true);
After some research I feel that spring-instrument is missing the required manifest attributes for Java 7 (see http://docs.oracle.com/javase/7/docs/api/java/lang/instrument/package-summary.html)
I'm neither an expert for instrumentation nor Gradle but I thought I'd give it a shot to at least start a discussion.