Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Objenesis proxy creation. #327

Closed
wants to merge 1 commit into from

Conversation

odrotbohm
Copy link
Member

Extended DefaultAopProxyFactory to create Objenesis based proxies if the library is on the classpath. This allows classes without a default constructor being CGLib proxied.

Open issues:

  • Make sure spring-context tests run against plain CGLib and CGLib + Objenesis (it only does the latter as of this change)

Issue: SPR-10594

@odrotbohm
Copy link
Member Author

/cc @philwebb, @cbeams, @jhoeller

@Fuud
Copy link

Fuud commented Aug 5, 2013

I already done it :)
Please take a look at #290

@philwebb
Copy link
Member

philwebb commented Aug 5, 2013

I think @olivergierke based his from your original pull request but with some modifications to allow Objenesis to be an optional dependency.

@Fuud
Copy link

Fuud commented Sep 2, 2013

/cc @philwebb @jhoeller

One task, SPR-10594, two implementations, two pull requests, 3 months, 0 comments, task in "Waiting for Triage" state.
Will be any progress ever? What are you waiting for?

Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default 
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails.

Objenesis 2.0 is now inlined into spring-core to avoid interfering with 
other Objenesis versions on the classpath.

Issue: SPR-10594
philwebb pushed a commit that referenced this pull request Sep 12, 2013
# By Oliver Gierke
* SPR-10594:
  Add support for Objenesis proxy creation.
@philwebb philwebb closed this Sep 12, 2013
@Fuud
Copy link

Fuud commented Sep 13, 2013

@philwebb Why you merged this request not mine?

@philwebb
Copy link
Member

@Fuud we went though several code iterations, the final result repackages objenesis as part of spring-core rather than it being an optional dependency. The net result should fix SPR-10594, let me know if you find problems.

Cheers for your original contribution, and for raising the issue. It was incredibly helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants