Change validate() overloaded methods check (SPR-11025) #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for overloaded methods, ConfigurationClass.validate() don't take in account overloaded methods from superclasses. The check was updated with the following steps - Add getParamerTypes to MethodMetadata interface - Split beanMethods Set into Lists by method name - For each bean method list, test that all have the same parameters Issue: SPR-11025
| * Returns an array of strings that represent the formal parameter types | ||
| * in declaration order. | ||
| */ | ||
| String[] getParameterTypes(); |
There was a problem hiding this comment.
Added to avoid casting MethodMetadata reference to StandarMethodMetada in ConfigurationClass.validate(). I think it makes sense because it defines the method when overloaded and does not introduce complex changes downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for overloaded methods, ConfigurationClass.validate()
don't take in account overloaded methods from superclasses.
The check was updated with the following steps
Issue: SPR-11025