remove allocation from NamedParameterUtils #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedParameterUtils first creates a substring before appending to a Appendable. This is unnecessary and creates a new `char[]` in later HotSpot versions. - use `Appendable#append` directly instead of creating substring first I did sign the Contributor License Agreement. Issue: SPR-11042
ghost
assigned 
|
Thanks for submitting the pull request! This has been addressed in commit 1dc7ff8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedParameterUtils first creates a substring before appending to a
Appendable. This is unnecessary and creates a new
char[]in laterHotSpot versions.
Appendable#appenddirectly instead of creating substring firstI did sign the Contributor License Agreement.
Issue: SPR-11042