Fix configuration class overriden/overloaded methods issues (SPR-10992, SPR-10988) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding bean methods from a configuration class, overridden methods from superclass are added too and it's bean definition overrides those declared in the subclass. The fix add a new method, getBeanMethodsToDefine that filter overriden methods for use in ConfigurationClassBeanDefinitionReader When overloading methods from a configuration class, the most specific subclass bean method is invoked only if - Argument types has the best match - Overloaded method in subclass has the same number of arguments. The fix sets the factory method to use from beanMethod metadata to RootBeanDefinition.resolvedConstructorOrFactoryMethod in ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForBeanMethod() to avoid looking for appropiate factory method in ConstructorResolver. Issues: SPR-10992, SPR-10988
|
Closed as both issues are now resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding bean methods from a configuration class,
overridden methods from superclass are added too and
it's bean definition overrides those declared in the subclass.
The fix add a new method, getBeanMethodsToDefine that filter
overriden methods for use in ConfigurationClassBeanDefinitionReader
When overloading methods from a configuration class, the most
specific subclass bean method is invoked only if
The fix sets the factory method to use from beanMethod metadata to
RootBeanDefinition.resolvedConstructorOrFactoryMethod in
ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForBeanMethod()
to avoid looking for appropiate factory method in ConstructorResolver later.
This pull request already includes changes from #390
Issues: SPR-10992, SPR-10988