Add merge support to nested collection properties #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test fails because <map merge="true"> attribute is not respected for nested property paths. Issue: SPR-9552
Prior to this commit, the merge attribute on nested collections was not handled properly which would result in the typical replacement behaviour. This is because during the merging of the parent and child beans the parent bean would have nested BeanDefinition objects while the child would have a property with the nested name (beanA.beanB.propertyName). When it came time to look for matching the property names it would be looking for the nested name which would not exist in the parent. The implementation of MutablePropertyValues.addProperty(PropertyValue) will now try to find a chain of nested BeanDefinition objects that match the nested property name and walk down the chain of beans and find the property and then merge if applicable. A JUnit test has been added to check for the new behaviour. Issue: SPR-9552
This was referenced Jan 11, 2019
spring-projects-issues
added
the
status: waiting-for-triage
|
@cbaldwin74 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
rstoyanchev
added
the
in: core
|
@cbaldwin74 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
Closing as the related issue has been declined |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the merge attribute on nested collections was not
handled properly which would result in the typical replacement
behaviour. This is because during the merging of the parent and child
beans the parent bean would have nested BeanDefinition objects while the
child would have a property with the nested name
(beanA.beanB.propertyName). When it came time to look for matching the
property names it would be looking for the nested name which would not
exist in the parent.
The implementation of MutablePropertyValues.addProperty(PropertyValue)
will now try to find a chain of nested BeanDefinition objects that match
the nested property name and walk down the chain of beans and find the
property and then merge if applicable.
A JUnit test has been added to check for the new behaviour.
Issue: SPR-9552
I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.