Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge support to nested collection properties #481

Closed
wants to merge 2 commits into from

Commits on Mar 1, 2014

  1. Test case for SPR-9552

    Unit test fails because <map merge="true"> attribute is not respected
    for nested property paths.
    
    Issue: SPR-9552
    cbaldwin74 committed Mar 1, 2014
    Configuration menu
    Copy the full SHA
    6a4ebe4 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2014

  1. Add merge support to nested collection properties

    Prior to this commit, the merge attribute on nested collections was not
    handled properly which would result in the typical replacement
    behaviour. This is because during the merging of the parent and child
    beans the parent bean would have nested BeanDefinition objects while the
    child would have a property with the nested name
    (beanA.beanB.propertyName). When it came time to look for matching the
    property names it would be looking for the nested name which would not
    exist in the parent.
    
    The implementation of MutablePropertyValues.addProperty(PropertyValue)
    will now try to find a chain of nested BeanDefinition objects that match
    the nested property name and walk down the chain of beans and find the
    property and then merge if applicable.
    
    A JUnit test has been added to check for the new behaviour.
    
    Issue: SPR-9552
    cbaldwin74 committed Mar 3, 2014
    Configuration menu
    Copy the full SHA
    bec2fd1 View commit details
    Browse the repository at this point in the history