Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc patch for RequestMapping (SPR-9483) #92

Closed
wants to merge 1 commit into from
Closed

Javadoc patch for RequestMapping (SPR-9483) #92

wants to merge 1 commit into from

Conversation

DavidBiesack
Copy link

Updated Javadoc for RequestMapping as suggested in
https://jira.springsource.org/browse/SPR-9483

 * <p>The format is a media type or sequence of media types,
 * with a request only mapped if the {@code Content-Type} matches one of these media types.
     * Examples: {@code consumes = "text/plain"} <code>consumes = {"text/plain", "application/*"}</code>

similar for produces.

Update 06/13/2012:
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

@rstoyanchev
Copy link
Contributor

Thanks for the pull request. You will need to sign the Contributor License agreement. See the guidelines. This is only one time and should be very quick.

@ghost ghost assigned rstoyanchev Jun 12, 2012
rstoyanchev added a commit that referenced this pull request Jun 18, 2012
* DavidBiesack-master:
  Minor fix in Javadoc for RequestMapping
@rstoyanchev
Copy link
Contributor

The change has been merged.

Note that I've corrected white space formatting (tabs instead of spaces), updated the commit comment with the issue number, and rebased the change on top of the latest in master. This means your fork needs a hard reset to correct its history. For the future I recommend submitting pull requests from a dedicated branch since you can then simply remove the temporary branch once the pull request has been merged.

@DavidBiesack
Copy link
Author

Rossen Stoyanchev reply@reply.github.com writes:

The change has been merged.

Note that I've corrected white space formatting (tabs instead of spaces), updated the commit comment with the issue number, and rebased the change on top of the latest in master. This means your fork needs a hard reset to correct its history. For the future I recommend submitting pull requests from a dedicated branch since you can then simply remove the temporary branch once the pull request has been merged.

Thanks. I'm very new to GitHub and somewhat of a Git novice. I missed the Help step of creating a branch in my fork before starting to make the change. Doh!

I've done a

git reset --hard

in my local source dir, but I don't know how to proceed to merge the file to match the version you committed. Or can/should I just remove my fork on GitHub? any harm in that (since I don't need it)?


Reply to this email directly or view it on GitHub:
#92 (comment)

@rstoyanchev
Copy link
Contributor

What I would usually do in those cases is "fetch" the changes from the Spring Framework repository and then do a reset to that. Assuming you have a remote for the Spring Framework called upstream you can do:

git fetch upstream
git checkout master
get reset --hard upstream/master

If you don't have a remote for the Spring framework, you can add it:

git remote add upstream https://github.com/SpringSource/spring-framework.git

I also recommend using something like gitk to visualize the commits and make inspect the results before and after the above operations.

If you don't have any changes to lose, you can always delete your fork and create it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants