Application does not start due to two bean instances of org.springframework.plugin.core.PluginRegistry (Follow-up) #1094

rainer198 · 2019-10-17T12:15:24Z

As explained in the last comment of #966 , an application using spring-hateoas-1.0.0 does not start if the bean factory is setup in a way that the ParameterNameDiscoverer is null or an alternative implementation.

The reason is that when autowiring of PluginRegistry into the bean _relProvider it finds two candidates and choosing one soley relies on the constructor argument name (same in EntityLinksConfigurationwhere the other instance of PluginRegistry is created.)

This could be easily resolved by using @Qualifier annotations and named beans.

The text was updated successfully, but these errors were encountered:

7fantasy7 · 2019-10-17T14:35:53Z

Having very similar issue after upgrading spring boot to 2.2.0

APPLICATION FAILED TO START

Description:

Parameter 0 of method linkDiscoverers in org.springframework.hateoas.config.HateoasConfiguration required a single bean, but 17 were found:
- modelBuilderPluginRegistry: defined in null
- modelPropertyBuilderPluginRegistry: defined in null
- typeNameProviderPluginRegistry: defined in null
- syntheticModelProviderPluginRegistry: defined in null
- documentationPluginRegistry: defined in null
- apiListingBuilderPluginRegistry: defined in null
- operationBuilderPluginRegistry: defined in null
- parameterBuilderPluginRegistry: defined in null
- expandedParameterBuilderPluginRegistry: defined in null
- resourceGroupingStrategyRegistry: defined in null
- operationModelsProviderPluginRegistry: defined in null
- defaultsProviderPluginRegistry: defined in null
- pathDecoratorRegistry: defined in null
- apiListingScannerPluginRegistry: defined in null
- relProviderPluginRegistry: defined by method 'relProviderPluginRegistry' in org.springframework.hateoas.config.HateoasConfiguration
- linkDiscovererRegistry: defined in null
- entityLinksPluginRegistry: defined by method 'entityLinksPluginRegistry' in class path resource [org/springframework/hateoas/config/WebMvcEntityLinksConfiguration.class]

Action:

Consider marking one of the beans as @primary, updating the consumer to accept multiple beans, or using @qualifier to identify the bean that should be consumed

ghost · 2019-10-22T09:36:06Z

Agree using spring-boot-starter-hateoas version 2.2.0.RELEASE get same error. Please fix this!

org.springframework.data spring-data-releasetrain Moore-RELEASE import pom

and springfox 2.9.2

mgargadennec · 2019-10-24T22:03:38Z

Same here after migration to Spring-Boot 2.2.0.RELEASE.

chadmalla-unity · 2019-10-24T22:37:41Z

Having very similar issue after upgrading spring boot to 2.2.0

APPLICATION FAILED TO START

Description:

Parameter 0 of method linkDiscoverers in org.springframework.hateoas.config.HateoasConfiguration required a single bean, but 17 were found:

modelBuilderPluginRegistry: defined in null

modelPropertyBuilderPluginRegistry: defined in null

typeNameProviderPluginRegistry: defined in null

syntheticModelProviderPluginRegistry: defined in null

documentationPluginRegistry: defined in null

apiListingBuilderPluginRegistry: defined in null

operationBuilderPluginRegistry: defined in null

parameterBuilderPluginRegistry: defined in null

expandedParameterBuilderPluginRegistry: defined in null

resourceGroupingStrategyRegistry: defined in null

operationModelsProviderPluginRegistry: defined in null

defaultsProviderPluginRegistry: defined in null

pathDecoratorRegistry: defined in null

apiListingScannerPluginRegistry: defined in null

relProviderPluginRegistry: defined by method 'relProviderPluginRegistry' in org.springframework.hateoas.config.HateoasConfiguration

linkDiscovererRegistry: defined in null

entityLinksPluginRegistry: defined by method 'entityLinksPluginRegistry' in class path resource [org/springframework/hateoas/config/WebMvcEntityLinksConfiguration.class]

Action:

Consider marking one of the beans as @primary, updating the consumer to accept multiple beans, or using @qualifier to identify the bean that should be consumed

+1 Would like to a see a solution for this error please

chadmalla-unity · 2019-10-24T23:01:51Z

The workaround I have at the moment is to remove all springfox related dependencies in the project and I no longer get the above error.

keshavsharma-github · 2019-10-25T06:37:50Z

@chadmalla-ff also facing the same issue.
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2019-10-25 12:06:23.321 ERROR 14400 --- [ restartedMain] o.s.b.d.LoggingFailureAnalysisReporter :

APPLICATION FAILED TO START

Description:

Parameter 0 of method linkDiscoverers in org.springframework.hateoas.config.HateoasConfiguration required a single bean, but 16 were found:
- modelBuilderPluginRegistry: defined in null
- modelPropertyBuilderPluginRegistry: defined in null
- typeNameProviderPluginRegistry: defined in null
- documentationPluginRegistry: defined in null
- apiListingBuilderPluginRegistry: defined in null
- operationBuilderPluginRegistry: defined in null
- parameterBuilderPluginRegistry: defined in null
- expandedParameterBuilderPluginRegistry: defined in null
- resourceGroupingStrategyRegistry: defined in null
- operationModelsProviderPluginRegistry: defined in null
- defaultsProviderPluginRegistry: defined in null
- pathDecoratorRegistry: defined in null
- apiListingScannerPluginRegistry: defined in null
- relProviderPluginRegistry: defined by method 'relProviderPluginRegistry' in class path resource [org/springframework/hateoas/config/HateoasConfiguration.class]
- linkDiscovererRegistry: defined in null
- entityLinksPluginRegistry: defined by method 'entityLinksPluginRegistry' in class path resource [org/springframework/hateoas/config/WebMvcEntityLinksConfiguration.class]

Action:

Consider marking one of the beans as @primary, updating the consumer to accept multiple beans, or using @qualifier to identify the bean that should be consumed.

Please provide inputs if you find any solution to this issue.

ghost · 2019-10-25T09:46:13Z

@chadmalla-ff it is not an option to remove all springfox deps

ghost · 2019-10-25T09:49:17Z

@rainer198 Understand making beans primary or such. But which beans to override from HateoasConfiguration?

gregturn · 2019-10-25T11:35:12Z

The community has identified springfox on the classpath as the key factor. Thanks for doing that.

How do you propose we test any potential changes? We don’t want to add springfox to this project since this project does nothing with that project.

ghost · 2019-10-25T13:06:23Z

@gregturn Understand it should be the springfox community who is responsible to be compatible with latest Spring Boot 2.2.0.RELEASE and it's subprojects. But while googling this it appears in your community.

ghost · 2019-10-25T15:26:00Z

@gregturn The reason to the error is that springfox uses an earlier version of spring-plugin which is not compatible with spring-hateoas which uses 2.0.0.RELEASE of the plugin. Tried to workaround this but realized it is not possible until springfox releases a new version using the latest spring-plugin version.

gregturn · 2019-10-29T14:23:25Z

I'm going to label this as invalid, since the real issue is that Spring HATEAOS is not presently compatible with Springfox (based on older versions of Spring Plugin and Spring Framework).

Feel free to track efforts on Springfox.

rainer198 · 2019-10-30T08:56:27Z

Sorry, have not been in office for a couple of days and missed the discussion here.

I do not agree that this is related to spring fox. I don't have spring fox on the classpath and can reproduce the issue.

The issue is that Spring HATEOAS relies on Spring autowiring fallback. If multiple candidate beans are found (here: multiple PluginRegistry beans) to be injected into another bean as constructor argument (here: relProvider), then Spring tries to guess the correct canidate by comparing bean names with constructor argument name. If any canidate matches this one is chosen.

However, it is possible to turn off this fallback in a spring application. One way is to set the ParameterNameDiscoverer to null in a BeanFactoryPostProcessor

@Override
public void postProcessBeanFactory(final ConfigurableListableBeanFactory beanFactory) {
	AbstractAutowireCapableBeanFactory factory = (AbstractAutowireCapableBeanFactory) beanFactory;
	factory.setParameterNameDiscoverer(null);
}

Doing this, the fallback mechanism is not able to resolve constructor arguments and can't decide for a candidate. Instead, an exception is thrown.

Turning off the fallback is a valid configuration in our opinion if you want to avoid autowiring the wrong instance of a bean by chance. The term "fallback" is also used by Spring (see org.springframework.beans.factory.support.DefaultListableBeanFactory, line 1537 .

Fixing this on Spring HATEOAS side is pretty simple. Each PluginRegistry bean should have explicit names (e.g. @Bean(name= relProviderPluginRegistry) and each constructor argument of type PluginRegistry should refer to exactly one of these names (e.g. @Qualifier("relProviderPluginRegistry")

edgarmariorivera · 2019-11-11T14:59:16Z

Hi guys, does anyone has a workaround for this? I would like to update my springboot app to 2.2.1 so we can use delayed instantiation feature.

Thanks

gregturn · 2019-11-11T15:17:04Z

@rainer198 That's an awfully quirky solution. It implies that you shouldn't use autowiring anywhere.

If multiple candidate beans are found (here: multiple PluginRegistry beans) to be injected into another bean as constructor argument (here: relProvider), then Spring tries to guess the correct canidate by comparing bean names with constructor argument name.

Take away Spring HATEOAS and instead look at any Spring application, and explain why we shouldn't presume we can do this.

If there are two PluginRegistry beans, that sounds like a problem in and of itself. Why do you need more than one?

rainer198 · 2019-11-12T09:34:53Z

If there are two PluginRegistry beans, that sounds like a problem in and of itself. Why do you need more than one?

It's not me needing more than one but you ;-)

One is defined in org.springframework.hateoas.config.HatoasConfiguration::relProviderPluginRegistry() consumed only in _relProvider(...) in the same configuration class.
another one on org.springframework.hateoas.config.EntityLinksConfiguration::entityLinksPluginRegistry() which is only consumed/autowired in delegatingEntityLinks(..) in the same configuration class

So, Spring HATEOAS instantiates two PluginRegistry beans, and the only way autowiring works here is based on a fallback based on parameter names. In our application this fallback has been turned off for reasons (we have a lot of beans of same interface, in our application and we wanted to force developers to explicitly state in a constructor which bean to use.)

laran · 2019-11-18T05:55:52Z

I have a similar issue. But I run into it when using spring-cloud-dataflow-rest-client and spring-boot-starter-test together.

<dependency>
	<groupId>org.springframework.boot</groupId>
	<artifactId>spring-boot-starter-test</artifactId>
	<version>2.2.1.RELEASE</version>
	<scope>test</scope>
	<exclusions>
		<exclusion>
			<groupId>org.junit.vintage</groupId>
			<artifactId>junit-vintage-engine</artifactId>
		</exclusion>
	</exclusions>
</dependency>

<dependency>
	<groupId>org.springframework.cloud</groupId>
	<artifactId>spring-cloud-dataflow-rest-client</artifactId>
	<version>2.2.1.RELEASE</version>
</dependency>

It seems to be something in spring-boot-starter-test that automatically loads all beans of a type.

chrisgleissner · 2019-12-30T09:52:42Z

Hi,

I am facing the same issue after trying to upgrade a project that relies on both Springfox and HATEOAS from Spring Boot 2.1 to Spring Boot 2.2. I see that @rainer198 suggested a solution within HATEOAS on October 30th. The ticket was then closed and the discussion fizzled out. But the problem remains.

Could @rainer198 's suggestion be incorporated into HATEOAS, @gregturn, or do you have any other suggestion on how this could be resolved (other than not upgrading at all or removing one of HateOAS or Springfox)? If I am forced to remove a library, it will most likely be HATEOAS as Springfox provides essential self-documentation of the REST API in the project.

Thanks

domselvon · 2020-01-10T10:59:03Z

I'm in the same boat as @chrisgleissner. If there's any chance this can be addressed in HateOAS as per @rainer198 's suggestion that woul dbe great. Otherwise, I'll also have to remove HateOAS from my application for the same reasons as @chrisgleissner.

Thanks in hopefulness.

driversti · 2020-03-19T09:09:00Z

Today I've faced the same problem.

<parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.2.5.RELEASE</version>
        <relativePath/> <!-- lookup parent from repository -->
 </parent>

<dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-swagger-ui</artifactId>
            <version>2.9.2</version>
</dependency>
<dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-swagger2</artifactId>
            <version>2.9.2</version>
</dependency>

chrisgleissner · 2020-03-19T11:52:18Z

I ended up replacing springfox with the better maintained springdoc-openapi-ui. Problem solved.

…

On Thu, Mar 19, 2020, 10:09 Yurii Chekhotskyi ***@***.***> wrote: Today I've faced the same problem. <parent> <groupId>org.springframework.boot</groupId> <artifactId>spring-boot-starter-parent</artifactId> <version>2.2.5.RELEASE</version> <relativePath/>  </parent> <dependency> <groupId>io.springfox</groupId> <artifactId>springfox-swagger-ui</artifactId> <version>2.9.2</version> </dependency> <dependency> <groupId>io.springfox</groupId> <artifactId>springfox-swagger2</artifactId> <version>2.9.2</version> </dependency> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1094 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6JA6ZEPAP33OCN5KGQPHTRIHOLXANCNFSM4JBYSWEQ> .

driversti · 2020-03-19T15:01:34Z

@chrisgleissner we did the same

SimonHasak · 2020-03-24T21:56:36Z

I had the same issue but after adding this dependency everything is working

<dependency>
<groupId>org.springframework.plugin</groupId>
<artifactId>spring-plugin-core</artifactId>
<version>2.0.0.RELEASE</version>
</dependency>

venkakat83 · 2020-03-27T02:42:36Z

I did following workaround to avoid spring Hateoas startup issue
Add following @bean in the application starter class

@Bean
public LinkDiscoverers discovers() {
	
	List<LinkDiscoverer> plugins = new ArrayList<>();
	plugins.add(new CollectionJsonLinkDiscoverer());
	return new LinkDiscoverers(SimplePluginRegistry.create(plugins));
	
}

chanchal99999 · 2020-03-27T05:00:39Z

I am facing the same problem
Is there any solution?

chanchal99999 · 2020-03-27T05:24:41Z

Add into SwaggerConfig
@bean
public LinkDiscoverers discovers() {

	List<LinkDiscoverer> plugins = new ArrayList<>();
	plugins.add(new CollectionJsonLinkDiscoverer());
	return new LinkDiscoverers(SimplePluginRegistry.create(plugins));
	
}

arielgiomi · 2020-05-14T22:24:50Z

@bean
public LinkDiscoverers discovers() {

List plugins = new ArrayList<>();
plugins.add(new CollectionJsonLinkDiscoverer());
return new LinkDiscoverers(SimplePluginRegistry.create(plugins));

}

Great! You're right!

ivan-caspeta-by · 2020-05-24T00:53:53Z

This is #1094 (comment) is the actual good solution along with
compile("org.springframework.plugin:spring-plugin-core:1.2.0.RELEASE") { force = true }, if you are using gradle, or just add the maven dependency.

progtiago · 2020-05-27T02:15:48Z

As @SimonHasak did, I solve this problem adding the dependency of spring core too.

<dependency>
<groupId>org.springframework.plugin</groupId>
<artifactId>spring-plugin-core</artifactId>
<version>2.0.0.RELEASE</version>
</dependency>

ignaciodm93 · 2021-02-08T14:51:44Z

Add into SwaggerConfig
@bean
public LinkDiscoverers discovers() {

	List<LinkDiscoverer> plugins = new ArrayList<>();
	plugins.add(new CollectionJsonLinkDiscoverer());
	return new LinkDiscoverers(SimplePluginRegistry.create(plugins));
	
}

Worked for me too. Thanks.

gs-snallaballi · 2021-03-04T07:13:33Z

I had the same issue but after adding this dependency everything is working

<dependency>
<groupId>org.springframework.plugin</groupId>
<artifactId>spring-plugin-core</artifactId>
<version>2.0.0.RELEASE</version>
</dependency>

Following the same approach, but I just upgraded SpringFox version to 3.0.0, which fixed the issue as it started pulling latest spring-plugin-core. Thank you All.

huangqitie-yyds · 2022-08-09T12:19:13Z

Add into SwaggerConfig @bean public LinkDiscoverers discovers() {

	List<LinkDiscoverer> plugins = new ArrayList<>();
	plugins.add(new CollectionJsonLinkDiscoverer());
	return new LinkDiscoverers(SimplePluginRegistry.create(plugins));
	
}

Thank you very much

gregturn added the resolution: invalid label Oct 29, 2019

gregturn closed this as completed Oct 29, 2019

chrisgleissner mentioned this issue Dec 30, 2019

Does not run in spring-boot 2.2.0 chrisgleissner/spring-batch-rest#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Application does not start due to two bean instances of org.springframework.plugin.core.PluginRegistry (Follow-up) #1094

Application does not start due to two bean instances of org.springframework.plugin.core.PluginRegistry (Follow-up) #1094

rainer198 commented Oct 17, 2019 •

edited

7fantasy7 commented Oct 17, 2019 •

edited

ghost commented Oct 22, 2019

mgargadennec commented Oct 24, 2019

chadmalla-unity commented Oct 24, 2019

chadmalla-unity commented Oct 24, 2019

keshavsharma-github commented Oct 25, 2019

ghost commented Oct 25, 2019

ghost commented Oct 25, 2019

gregturn commented Oct 25, 2019

ghost commented Oct 25, 2019 •

edited by ghost

ghost commented Oct 25, 2019

gregturn commented Oct 29, 2019

rainer198 commented Oct 30, 2019

edgarmariorivera commented Nov 11, 2019

gregturn commented Nov 11, 2019

rainer198 commented Nov 12, 2019

laran commented Nov 18, 2019 •

edited

chrisgleissner commented Dec 30, 2019

domselvon commented Jan 10, 2020

driversti commented Mar 19, 2020

chrisgleissner commented Mar 19, 2020 via email

driversti commented Mar 19, 2020

SimonHasak commented Mar 24, 2020 •

edited

venkakat83 commented Mar 27, 2020

chanchal99999 commented Mar 27, 2020

chanchal99999 commented Mar 27, 2020

arielgiomi commented May 14, 2020

ivan-caspeta-by commented May 24, 2020

progtiago commented May 27, 2020 •

edited

ignaciodm93 commented Feb 8, 2021

gs-snallaballi commented Mar 4, 2021 •

edited

huangqitie-yyds commented Aug 9, 2022

Application does not start due to two bean instances of org.springframework.plugin.core.PluginRegistry (Follow-up) #1094

Application does not start due to two bean instances of org.springframework.plugin.core.PluginRegistry (Follow-up) #1094

Comments

rainer198 commented Oct 17, 2019 • edited

7fantasy7 commented Oct 17, 2019 • edited

ghost commented Oct 22, 2019

mgargadennec commented Oct 24, 2019

chadmalla-unity commented Oct 24, 2019

chadmalla-unity commented Oct 24, 2019

keshavsharma-github commented Oct 25, 2019

ghost commented Oct 25, 2019

ghost commented Oct 25, 2019

gregturn commented Oct 25, 2019

ghost commented Oct 25, 2019 • edited by ghost

ghost commented Oct 25, 2019

gregturn commented Oct 29, 2019

rainer198 commented Oct 30, 2019

edgarmariorivera commented Nov 11, 2019

gregturn commented Nov 11, 2019

rainer198 commented Nov 12, 2019

laran commented Nov 18, 2019 • edited

chrisgleissner commented Dec 30, 2019

domselvon commented Jan 10, 2020

driversti commented Mar 19, 2020

chrisgleissner commented Mar 19, 2020 via email

driversti commented Mar 19, 2020

SimonHasak commented Mar 24, 2020 • edited

venkakat83 commented Mar 27, 2020

chanchal99999 commented Mar 27, 2020

chanchal99999 commented Mar 27, 2020

arielgiomi commented May 14, 2020

ivan-caspeta-by commented May 24, 2020

progtiago commented May 27, 2020 • edited

ignaciodm93 commented Feb 8, 2021

gs-snallaballi commented Mar 4, 2021 • edited

huangqitie-yyds commented Aug 9, 2022

rainer198 commented Oct 17, 2019 •

edited

7fantasy7 commented Oct 17, 2019 •

edited

ghost commented Oct 25, 2019 •

edited by ghost

laran commented Nov 18, 2019 •

edited

SimonHasak commented Mar 24, 2020 •

edited

progtiago commented May 27, 2020 •

edited

gs-snallaballi commented Mar 4, 2021 •

edited