Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted mappings still contain regex matching expressions #1412

Closed
odrotbohm opened this issue Dec 12, 2020 · 0 comments
Closed

Extracted mappings still contain regex matching expressions #1412

odrotbohm opened this issue Dec 12, 2020 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core parts of the project type: bug
Milestone
1.3 M1

Comments

@odrotbohm
Copy link
Member

For a mapping @GetMapping("/foo/{bar:[ABC{2}]}" the returned mapping is still /foo/{bar:[ABC]{2}}, when it should be /foo/{bar}.
@odrotbohm odrotbohm added type: bug in: core Core parts of the project labels Dec 12, 2020
@odrotbohm odrotbohm added this to the 1.3 M1 milestone Dec 12, 2020
@odrotbohm odrotbohm self-assigned this Dec 12, 2020
This was referenced Dec 12, 2020
Closed
Closed
odrotbohm added a commit that referenced this issue Dec 12, 2020
@odrotbohm
#1413 - Discovered mappings now get regex matchers removed.
f008e75 
We now remove potentially used regular expression matchers from template variables to avoid the to show up in links generated for the templates.

Backport of #1412.
odrotbohm added a commit that referenced this issue Dec 12, 2020
@odrotbohm
#1412 - Discovered mappings now get regex matchers removed.
93dfe16 
We now remove potentially used regular expression matchers from template variables to avoid the to show up in links generated for the templates.
odrotbohm added a commit that referenced this issue Dec 12, 2020
@odrotbohm
#1414 - Discovered mappings now get regex matchers removed.
8c4420b 
We now remove potentially used regular expression matchers from template variables to avoid the to show up in links generated for the templates.

Backport of #1412.
@odrotbohm odrotbohm mentioned this issue Feb 10, 2021
Closed
odrotbohm added a commit that referenced this issue Feb 10, 2021
@odrotbohm
#1450 - Fix template variable cleanup for variables using regular exp…
0f2ac8e 
…ressions.

Switched to manual parsing of template variables as regular expressions can contain { and } characters which makes matching variables using these as delimiters impossible.

Related ticket: #1412.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core parts of the project type: bug
Projects
None yet
Milestone
1.3 M1
Development

No branches or pull requests
1 participant
@odrotbohm