Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logref property should be optional #1025

Closed
wants to merge 2 commits into from

Conversation

mateusz-lisik
Copy link

Originally mentioned in issue #478 - logref property in spring-hateoas project is required to have value, where in vnd.error specification this field is optional.

@pivotal-issuemaster
Copy link

@matteprl Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@matteprl Thank you for signing the Contributor License Agreement!

@gregturn
Copy link
Contributor

I agree the spec shows it to be optional and not required.

Are you able to update/add test cases that demonstrate vnd.error documents being rendered properly into JSON when logref is null?

@mateusz-lisik
Copy link
Author

@gregturn Sure, will do.

@gregturn
Copy link
Contributor

Resolved via 4f3be11.

@gregturn gregturn closed this Dec 10, 2019
@gregturn gregturn added this to the 1.1.0.M1 milestone Dec 10, 2019
@gregturn
Copy link
Contributor

Feel free to take the snapshots out for a spin @matteprl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants