Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix typos, document links, and grammatical errors #1190

Conversation

rolandkrueger
Copy link
Contributor

I found two unfinished sentences which I could not complete. I marked them with an ellipsis (...) so that they stand out a bit more. They still need to be completed by a maintainer:

  • mediatypes.adoc: "Extract the properties from the EntityModel and turn them into ..."
  • server.adoc: "Just as you can create links by pointing to Spring MVC controller methods (see <<server.link-builder.webmvc>> for details) you ..."

Unfinished sentences were marked with ellipsis ...
@pivotal-issuemaster
Copy link

@rolandkrueger Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rolandkrueger
Copy link
Contributor Author

@pivotal-issuemaster This is an Obvious Fix

@pivotal-issuemaster
Copy link

@rolandkrueger This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@rolandkrueger rolandkrueger changed the title Fix typos, document links, and grammatical errors Documentation: Fix typos, document links, and grammatical errors Jan 28, 2020
@odrotbohm
Copy link
Member

Highly appreciated, Roland. I'll have a look tomorrow morning.

@odrotbohm odrotbohm self-assigned this Jan 28, 2020
@rolandkrueger
Copy link
Contributor Author

Thanks, you're welcome!

odrotbohm pushed a commit that referenced this pull request Feb 3, 2020
Unfinished sentences were marked with ellipsis….
odrotbohm pushed a commit that referenced this pull request Feb 3, 2020
Unfinished sentences were marked with ellipsis….
@odrotbohm
Copy link
Member

That's merged and back-ported. Thanks again for that thorough review!

@odrotbohm odrotbohm closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants