Drop H2 schema before JDBC tests

https://build.spring.io/browse/INT-MJATS41-1679/ # Conflicts: # spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/store/JdbcMessageStoreChannelTests-context.xml # spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/store/JdbcMessageStoreRegionTests.java
spring-projects · Apr 9, 2019 · 8219aba · 8219aba
1 parent ad8d836
commit 8219aba
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/...ava/org/springframework/integration/jdbc/leader/JdbcLockRegistryLeaderInitiatorTests.java b/...ava/org/springframework/integration/jdbc/leader/JdbcLockRegistryLeaderInitiatorTests.java
@@ -55,6 +55,7 @@ public class JdbcLockRegistryLeaderInitiatorTests {
 	public static void init() {
 		dataSource = new EmbeddedDatabaseBuilder()
 				.setType(EmbeddedDatabaseType.H2)
+				.addScript("classpath:/org/springframework/integration/jdbc/schema-drop-h2.sql")
 				.addScript("classpath:/org/springframework/integration/jdbc/schema-h2.sql")
 				.build();
 	}
@@ -68,7 +69,7 @@ public static void destroy() {
 	public void testDistributedLeaderElection() throws Exception {
 		CountDownLatch granted = new CountDownLatch(1);
 		CountingPublisher countingPublisher = new CountingPublisher(granted);
-		List<LockRegistryLeaderInitiator> initiators = new ArrayList<LockRegistryLeaderInitiator>();
+		List<LockRegistryLeaderInitiator> initiators = new ArrayList<>();
 		for (int i = 0; i < 2; i++) {
 			DefaultLockRepository lockRepository = new DefaultLockRepository(dataSource);
 			lockRepository.afterPropertiesSet();

diff --git a/.../java/org/springframework/integration/jdbc/store/JdbcMessageStoreChannelTests-context.xml b/.../java/org/springframework/integration/jdbc/store/JdbcMessageStoreChannelTests-context.xml
@@ -13,6 +13,7 @@
 	<jdbc:embedded-database id="dataSource" type="H2" />
 
 	<jdbc:initialize-database data-source="dataSource">
+		<jdbc:script location="org/springframework/integration/jdbc/schema-drop-h2.sql"/>
 		<jdbc:script location="org/springframework/integration/jdbc/schema-h2.sql" />
 	</jdbc:initialize-database>
 

diff --git a/...src/test/java/org/springframework/integration/jdbc/store/JdbcMessageStoreRegionTests.java b/...src/test/java/org/springframework/integration/jdbc/store/JdbcMessageStoreRegionTests.java
@@ -29,26 +29,29 @@
 
 import org.springframework.integration.support.MessageBuilder;
 import org.springframework.jdbc.core.JdbcTemplate;
-import org.springframework.jdbc.core.RowMapper;
 import org.springframework.jdbc.datasource.embedded.EmbeddedDatabase;
 import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder;
 import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType;
 
 /**
  * @author Gunnar Hillert
+ * @author Artem Bilan
  */
 public class JdbcMessageStoreRegionTests {
 
 	private static EmbeddedDatabase dataSource;
+
 	private JdbcTemplate jdbcTemplate;
 
 	private JdbcMessageStore messageStore1;
+
 	private JdbcMessageStore messageStore2;
 
 	@BeforeClass
 	public static void setupDatabase() {
 		dataSource = new EmbeddedDatabaseBuilder()
 				.setType(EmbeddedDatabaseType.H2)
+				.addScript("classpath:/org/springframework/integration/jdbc/schema-drop-h2.sql")
 				.addScript("classpath:/org/springframework/integration/jdbc/schema-h2.sql")
 				.build();
 	}
@@ -76,7 +79,7 @@ public void afterTest() {
 	}
 
 	@Test
-	public void testVerifyMessageCount() throws Exception {
+	public void testVerifyMessageCount() {
 
 		messageStore1.addMessage(MessageBuilder.withPayload("payload1").build());
 		messageStore1.addMessage(MessageBuilder.withPayload("payload2").build());
@@ -90,7 +93,7 @@ public void testVerifyMessageCount() throws Exception {
 	}
 
 	@Test
-	public void testInsertNullRegion() throws Exception {
+	public void testInsertNullRegion() {
 
 		try {
 			messageStore1.setRegion(null);
@@ -104,7 +107,7 @@ public void testInsertNullRegion() throws Exception {
 	}
 
 	@Test
-	public void testVerifyMessageGroupCount() throws Exception {
+	public void testVerifyMessageGroupCount() {
 
 		messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
 		messageStore1.addMessageToGroup("group2", MessageBuilder.withPayload("payload2").build());
@@ -123,28 +126,28 @@ public void testVerifyMessageGroupCount() throws Exception {
 	}
 
 	@Test
-	public void testRegionSetToMessageGroup() throws Exception {
+	public void testRegionSetToMessageGroup() {
 
 		messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
 
 		List<String> regions = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region1'",
-				(RowMapper<String>) (rs, rowNum) -> rs.getString("REGION"));
+				(rs, rowNum) -> rs.getString("REGION"));
 
 		assertEquals(1, regions.size());
 		assertEquals("region1", regions.get(0));
 
 		messageStore2.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
 
 		List<String> regions2 = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region2'",
-				(RowMapper<String>) (rs, rowNum) -> rs.getString("REGION"));
+				(rs, rowNum) -> rs.getString("REGION"));
 
 		assertEquals(1, regions2.size());
 		assertEquals("region2", regions2.get(0));
 
 	}
 
 	@Test
-	public void testRemoveMessageGroup() throws Exception {
+	public void testRemoveMessageGroup() {
 
 		messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
 		messageStore1.addMessageToGroup("group2", MessageBuilder.withPayload("payload2").build());
@@ -158,4 +161,5 @@ public void testRemoveMessageGroup() throws Exception {
 		assertEquals(2, messageStore2.getMessageGroupCount());
 
 	}
+
 }