Skip to content

Commit

Permalink
GH-3271: Close session on error in stream source
Browse files Browse the repository at this point in the history
Fixes #3271

When exception happens at `.withPayload(session.readRaw(remotePath))`
in the `AbstractRemoteFileStreamingMessageSource` we don't close session.
The resource leaking happens in the caching session factory

* Add `session.close();` into the `catch (IOException e) {`
in the `AbstractRemoteFileStreamingMessageSource.doReceive()`
to clean up resources properly

**Cherry-pick to 5.2.x, 5.1.x & 4.3.x**
  • Loading branch information
artembilan authored and garyrussell committed May 11, 2020
1 parent c00c319 commit 96cf146
Show file tree
Hide file tree
Showing 2 changed files with 143 additions and 0 deletions.
Expand Up @@ -175,6 +175,7 @@ protected Object doReceive() {
.build();
}
catch (IOException e) {
session.close();
throw new MessagingException("IOException when retrieving " + remotePath, e);
}
}
Expand Down
@@ -0,0 +1,142 @@
/*
* Copyright 2015-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.integration.file.remote;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import java.io.IOException;
import java.util.Collection;
import java.util.Comparator;
import java.util.List;
import java.util.stream.Collectors;

import org.junit.Test;
import org.mockito.Mockito;

import org.springframework.beans.factory.BeanFactory;
import org.springframework.integration.file.remote.session.CachingSessionFactory;
import org.springframework.integration.file.remote.session.Session;
import org.springframework.integration.file.remote.session.SessionFactory;
import org.springframework.messaging.MessagingException;

/**
* @author Lukas Gemela
* @author Artem Bilan
*
* @since 5.2.2
*
*/
public class RemoteFileStreamingMessageSourceTests {

@Test
@SuppressWarnings("unchecked")
public void sessionReturnedToCacheProperlyOnDoReceive() throws IOException {
Session<String> session = mock(Session.class);
when(session.readRaw(Mockito.anyString())).thenThrow(IOException.class);
when(session.list("remoteDirectory")).thenReturn(new String[] { "file1" });

SessionFactory<String> sessionFactory = mock(SessionFactory.class);
when(sessionFactory.getSession()).thenReturn(session);

CachingSessionFactory<String> cachingSessionFactory = new CachingSessionFactory<>(sessionFactory, 1);
RemoteFileTemplate<String> remoteFileTemplate = new RemoteFileTemplate<>(cachingSessionFactory);

TestRemoteFileStreamingMessageSource testRemoteFileStreamingMessageSource =
new TestRemoteFileStreamingMessageSource(remoteFileTemplate, null);

testRemoteFileStreamingMessageSource.setRemoteDirectory("remoteDirectory");
testRemoteFileStreamingMessageSource.setBeanFactory(mock(BeanFactory.class));
testRemoteFileStreamingMessageSource.start();

try {
testRemoteFileStreamingMessageSource.doReceive();
}
catch (MessagingException ex) {
}

}

static class TestRemoteFileStreamingMessageSource extends AbstractRemoteFileStreamingMessageSource<String> {

TestRemoteFileStreamingMessageSource(RemoteFileTemplate<String> template,
Comparator<AbstractFileInfo<String>> comparator) {

super(template, comparator);
}

@Override
protected List<AbstractFileInfo<String>> asFileInfoList(Collection<String> files) {
return files
.stream()
.map(TestFileInfo::new)
.collect(Collectors.toList());
}

@Override
public String getComponentType() {
return null;
}

}

static class TestFileInfo extends AbstractFileInfo<String> {

TestFileInfo(String fileName) {
this.fileName = fileName;
}

private final String fileName;

@Override
public boolean isDirectory() {
return false;
}

@Override
public boolean isLink() {
return false;
}

@Override
public long getSize() {
return 0;
}

@Override
public long getModified() {
return 0;
}

@Override
public String getFilename() {
return fileName;
}

@Override
public String getPermissions() {
return null;
}

@Override
public String getFileInfo() {
return null;
}

}

}

0 comments on commit 96cf146

Please sign in to comment.