Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the MessagingMethodInvokerHelper complexity and consider to add out-of-the-box beans for the MessageHandlerMethodFactory #2690

Closed
artembilan opened this issue Jan 10, 2019 · 0 comments · Fixed by #2798
Closed

Revise the MessagingMethodInvokerHelper complexity and consider to add out-of-the-box beans for the MessageHandlerMethodFactory #2690

artembilan opened this issue Jan 10, 2019 · 0 comments · Fixed by #2798
Assignees
@artembilan
Labels
in: core
Milestone
5.2.M1

Comments

@artembilan
Copy link
Member

See more discussion in the #2688
@artembilan artembilan mentioned this issue Jan 10, 2019
Closed
@artembilan artembilan added this to the 5.2.M1 milestone Mar 8, 2019
@artembilan artembilan self-assigned this Mar 8, 2019
artembilan added a commit to artembilan/spring-integration that referenced this issue Mar 9, 2019
@artembilan
spring-projectsGH-2690: Add MessageHandlerMethodFactory beans
122894f 
Fixes spring-projects#2690

For more end-user flexibility and for simplicity of the `MessagingMethodInvokerHelper`
logic, add `IntegrationContextUtils.MESSAGE_HANDLER_FACTORY_BEAN_NAME` and
`IntegrationContextUtils.LIST_MESSAGE_HANDLER_FACTORY_BEAN_NAME`
infrastructure beans

* Use mentioned beans in the `MessagingMethodInvokerHelper` if any,
otherwise fallback to the locally configured `MessageHandlerMethodFactory`,
although this is necessary only for our non-Spring-based unit tests
* Relax `BeanFactory` requirement for the `EvaluationContext` since it
is going to be there in the Spring-based environment, but might not be
available in the plain unit tests
* Provide some optimization and refactoring for the `MessagingMethodInvokerHelper`
* Remove deprecated `HandlerMethodArgumentResolversHolder` and
`ARGUMENT_RESOLVERS_BEAN_NAME` & `LIST_ARGUMENT_RESOLVERS_BEAN_NAME`
bean definitions and constants for their names
@artembilan artembilan mentioned this issue Mar 9, 2019
Merged
garyrussell pushed a commit that referenced this issue Mar 13, 2019
@artembilan @garyrussell
GH-2690: Add MessageHandlerMethodFactory beans (#2798)
d53433c 
* GH-2690: Add MessageHandlerMethodFactory beans

Fixes #2690

For more end-user flexibility and for simplicity of the `MessagingMethodInvokerHelper`
logic, add `IntegrationContextUtils.MESSAGE_HANDLER_FACTORY_BEAN_NAME` and
`IntegrationContextUtils.LIST_MESSAGE_HANDLER_FACTORY_BEAN_NAME`
infrastructure beans

* Use mentioned beans in the `MessagingMethodInvokerHelper` if any,
otherwise fallback to the locally configured `MessageHandlerMethodFactory`,
although this is necessary only for our non-Spring-based unit tests
* Relax `BeanFactory` requirement for the `EvaluationContext` since it
is going to be there in the Spring-based environment, but might not be
available in the plain unit tests
* Provide some optimization and refactoring for the `MessagingMethodInvokerHelper`
* Remove deprecated `HandlerMethodArgumentResolversHolder` and
`ARGUMENT_RESOLVERS_BEAN_NAME` & `LIST_ARGUMENT_RESOLVERS_BEAN_NAME`
bean definitions and constants for their names

* * Revert `getEvaluationContext(false)` usage.
* Fix `MessagingMethodInvokerHelper` to propagate `BeanFactory` to
argument resolvers if any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: core
Projects
None yet
Milestone
5.2.M1
Development

Successfully merging a pull request may close this issue.

GH-2690: Add MessageHandlerMethodFactory beans artembilan/spring-integration
2 participants
@garyrussell @artembilan