Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression - NIO TcpConnectionOpenEvent published to early #3299

Closed
garyrussell opened this issue Jun 9, 2020 · 0 comments · Fixed by #3300
Closed

Regression - NIO TcpConnectionOpenEvent published to early #3299

garyrussell opened this issue Jun 9, 2020 · 0 comments · Fixed by #3300
Assignees
@garyrussell
Labels
in: TCP/UDP type: bug type: regression
Milestone
5.3.1

Comments

@garyrussell
Copy link
Contributor

Introduced when we added connection timeout support: 466daa8#diff-c5b8d701d6369ca2fed8cbb0f8086eab

https://stackoverflow.com/questions/62291284/triggering-actions-upon-clientconnectionfactory-connection-establishment-accep
@garyrussell garyrussell added this to the 5.3.1 milestone Jun 9, 2020
@garyrussell garyrussell self-assigned this Jun 9, 2020
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jun 10, 2020
@garyrussell
spring-projectsGH-3299: Fix client connectionId for TCP/NIO
de4a685 
Resolves spring-projects#3299

Connect before creating the `TcpNioConnection` object and publishing the
`TcpConnectionOpenEvent`.

This was a regression caused by supporting connect timout; which moved
the connect to after the object was created and event published, causing
the `connectionId` to start with `unknown`.

**cherry-pick to 5.3.x, 5.2.x**
@garyrussell garyrussell mentioned this issue Jun 10, 2020
Merged
artembilan pushed a commit that referenced this issue Jun 10, 2020
@garyrussell @artembilan
GH-3299: Fix client connectionId for TCP/NIO
7ec1f5c 
Resolves #3299

Connect before creating the `TcpNioConnection` object and publishing the
`TcpConnectionOpenEvent`.

This was a regression caused by supporting connect timout; which moved
the connect to after the object was created and event published, causing
the `connectionId` to start with `unknown`.

**cherry-pick to 5.3.x, 5.2.x**
artembilan pushed a commit that referenced this issue Jun 10, 2020
@garyrussell
GH-3299: Fix client connectionId for TCP/NIO
29e8f07 
Resolves #3299

Connect before creating the `TcpNioConnection` object and publishing the
`TcpConnectionOpenEvent`.

This was a regression caused by supporting connect timout; which moved
the connect to after the object was created and event published, causing
the `connectionId` to start with `unknown`.

**cherry-pick to 5.3.x, 5.2.x**
artembilan pushed a commit that referenced this issue Jun 10, 2020
@garyrussell
GH-3299: Fix client connectionId for TCP/NIO
1df9186 
Resolves #3299

Connect before creating the `TcpNioConnection` object and publishing the
`TcpConnectionOpenEvent`.

This was a regression caused by supporting connect timout; which moved
the connect to after the object was created and event published, causing
the `connectionId` to start with `unknown`.

**cherry-pick to 5.3.x, 5.2.x**
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: TCP/UDP type: bug type: regression
Projects
None yet
Milestone
5.3.1
Development

Successfully merging a pull request may close this issue.

GH-3299: Fix client connectionId for TCP/NIO garyrussell/spring-integration
1 participant
@garyrussell