Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise error handling in the ReactiveRedisStreamMessageProducer #3439

Closed
artembilan opened this issue Dec 7, 2020 · 0 comments
Closed

Revise error handling in the ReactiveRedisStreamMessageProducer #3439

artembilan opened this issue Dec 7, 2020 · 0 comments
Assignees
@artembilan
Labels
in: redis type: enhancement
Milestone
5.5 M1

Comments

@artembilan
Copy link
Member

Currently the error handling is done via onErrorContinue().
Looks like a recommended way is to configure an onErrorResume() on the StreamReceiver.
See https://jira.spring.io/browse/DATAREDIS-1230 for more info.
@artembilan artembilan added this to the 5.5 M1 milestone Dec 7, 2020
Closed
@artembilan artembilan self-assigned this Jan 20, 2021
artembilan added a commit to artembilan/spring-integration that referenced this issue Jan 20, 2021
@artembilan
spring-projectsGH-3439: Revise error handling in RedisStreamMP
0d2cf1b 
Fixes spring-projects#3439

The latest Spring Data Redis has introduced an `onErrorResume` function
option for the `StreamReceiver` and this one is now recommended way
to handle errors in the `Flux` from this receiver

* Expose all the `StreamReceiver.StreamReceiverOptionsBuilder` option
onto the `ReactiveRedisStreamMessageProducer`, including `onErrorResume`
* Have a default function as it was before - send into an error channel
supporting (n)ack in the failed message based on the failed record
* Make new setters mutually exclusive with an explicit `StreamReceiver.StreamReceiverOptions`
@artembilan artembilan mentioned this issue Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: redis type: enhancement
Projects
None yet
Milestone
5.5 M1
Development

Successfully merging a pull request may close this issue.

GH-3439: Revise error handling in RedisStreamMP artembilan/spring-integration
1 participant
@artembilan