Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elasticsearch support #3527

Open
JianboDM opened this issue Mar 25, 2021 · 6 comments
Open

Add Elasticsearch support #3527

JianboDM opened this issue Mar 25, 2021 · 6 comments
Labels
status: waiting-for-triage The issue need to be evaluated and its future decided type: enhancement
Milestone

Comments

@JianboDM
Copy link

JianboDM commented Mar 25, 2021

Does this project support elasticsearch?if not,Do you plan to support elasticsearch?

@JianboDM JianboDM added status: waiting-for-triage The issue need to be evaluated and its future decided type: enhancement labels Mar 25, 2021
@artembilan
Copy link
Member

The project is based mostly on the community-driver-feedback. So, if there is no demand for Elasticsearch, then there is no support in the project. But it doesn't mean that we won't add it in the future if community (you) asks for it.

We also are very open for Contribution becuase we may be busy with some other priorities, like fixing and improving already existing features.

If you already have some ideas how it can be incorporated into a project, we are very likely to accept a PR for the current 5.5 version or the next one. Or we can extract it into a extension project like we have so far for Apache Cassandra and Hazelcast: https://github.com/spring-projects/spring-integration-extensions.

I saw recently that our new Stream Applications project - Serverless Functions for Spring Integration components and similar - has gotten a contribution for Elasticsearch Consumer. So, that could be as a great starting point how to implement respective channel adapter in Spring Integration.

@artembilan artembilan added this to the Backlog milestone Mar 25, 2021
@artembilan artembilan changed the title elasticsearch support Add Elasticsearch support Mar 25, 2021
@migroskub
Copy link
Contributor

The project is based mostly on the community-driver-feedback. So, if there is no demand for Elasticsearch, then there is no support for the project.

@artembilan But there is. And so for all of the other requested channel adapters. This project for some reason doesn't add support for the most common and standard databases and technologies in the industry, even though it is being developed for years. I don't expect special functionalities or something. Just bulk-based channel adapters for most of the databases (addition of a channel adapter won't take more than 1-2 days for a developer who knows this library well).

@artembilan
Copy link
Member

Sure, @migroskub !

We are just short-handed over here in our team for the project.
Plus I'm not familiar with Elasticsearch to jump into an implementation immediately.
Therefore I'm asking for a contribution which I'll gladly review quickly and so on.

Thanks for understanding!

@migroskub
Copy link
Contributor

@artembilan I understand and I’ll try to find the right time for contribution of some channel adapters. Anyway, writing to ES with Spring is super easy. Basic familiarity with the ReactiveElasticsearchClient should be enough.

@rolkhas2
Copy link

rolkhas2 commented Jul 16, 2022

I don't understand why doesn't this channel adapter documented here. I'm struggling with finding a way of using it.

@artembilan
Copy link
Member

@rolkhas2 ,

there is just not Elasticsearch support in this project yet, therefore no docs on the matter.
This issue is exactly about implementing those and document them properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage The issue need to be evaluated and its future decided type: enhancement
Projects
None yet
Development

No branches or pull requests

4 participants