Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up JdbcLockRegistry, ZookeeperLockRegistry cache automatically #3672

Closed
Meteorkor opened this issue Nov 11, 2021 · 0 comments · Fixed by #3673
Closed

Clean up JdbcLockRegistry, ZookeeperLockRegistry cache automatically #3672

Meteorkor opened this issue Nov 11, 2021 · 0 comments · Fixed by #3673
Labels
in: jdbc in: zookeeper type: enhancement
Milestone
5.5.6

Comments

@Meteorkor
Copy link
Contributor

Expected Behavior
If you're okay
I'm working on it and I'm trying to post a PR.

Current Behavior
now
If you use a lot of different keys
Currently, you have to call expireUnusedOlderThan() manually.

after change
Developers can use it without manually invoking it.
If you do not want local caching, you can also disable caching by setting capacity.

Context

Similar to an issue before, I'd like to contribute.
#3655
@Meteorkor Meteorkor added status: waiting-for-triage The issue need to be evaluated and its future decided type: enhancement labels Nov 11, 2021
@Meteorkor Meteorkor mentioned this issue Nov 11, 2021
Merged
@artembilan artembilan added this to the 5.5.6 milestone Nov 11, 2021
@artembilan artembilan added in: jdbc in: zookeeper and removed status: waiting-for-triage The issue need to be evaluated and its future decided labels Nov 11, 2021
artembilan pushed a commit that referenced this issue Nov 11, 2021
@Meteorkor
GH-3672: Clean up Jdbc & ZK LockRegistry caches
db61102 
Fixes #3672

* Clean up `JdbcLockRegistry`, `ZookeeperLockRegistry` cache automatically 
* setCapacity(int capacity) to cacheCapacity(int capacity)
* field rename `capacity`to `cacheCapacity`, add static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: jdbc in: zookeeper type: enhancement
Projects
None yet
Milestone
5.5.6
Development

Successfully merging a pull request may close this issue.

Clean up JdbcLockRegistry, ZookeeperLockRegistry cache automatically Meteorkor/spring-integration
2 participants
@artembilan @Meteorkor