Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageBuilder.setExpirationDate(expirationDate) should be marked as @Nullable #8754

Closed
mrpiggi opened this issue Oct 9, 2023 · 0 comments · Fixed by #8755
Closed

MessageBuilder.setExpirationDate(expirationDate) should be marked as @Nullable #8754

mrpiggi opened this issue Oct 9, 2023 · 0 comments · Fixed by #8755

Comments

@mrpiggi
Copy link
Contributor

mrpiggi commented Oct 9, 2023

As

public AbstractIntegrationMessageBuilder<T> setExpirationDate(@Nullable Date expirationDate) {
if (expirationDate != null) {
return setHeader(IntegrationMessageHeaderAccessor.EXPIRATION_DATE, expirationDate.getTime());
}
else {
return setHeader(IntegrationMessageHeaderAccessor.EXPIRATION_DATE, null);
}
}

is marked as @Nullable expirationDate this should also be valid for
public AbstractIntegrationMessageBuilder<T> setExpirationDate(Long expirationDate) {
return setHeader(IntegrationMessageHeaderAccessor.EXPIRATION_DATE, expirationDate);
}

as well as
@Override
public MessageBuilder<T> setExpirationDate(Long expirationDate) {
super.setExpirationDate(expirationDate);
return this;
}
@Override
public MessageBuilder<T> setExpirationDate(Date expirationDate) {
super.setExpirationDate(expirationDate);
return this;
}

@mrpiggi mrpiggi added status: waiting-for-triage The issue need to be evaluated and its future decided type: bug labels Oct 9, 2023
@artembilan artembilan added this to the 6.2.0-RC1 milestone Oct 10, 2023
@artembilan artembilan added in: core backport 6.0.x (EOL) for: backport-to-6.1.x and removed status: waiting-for-triage The issue need to be evaluated and its future decided labels Oct 10, 2023
artembilan pushed a commit that referenced this issue Oct 10, 2023
Fixes #8754

* `AbstractIntegrationMessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Date expirationDate)`

**Cherry-pick to `6.1.x` & `6.0.x`**
artembilan pushed a commit that referenced this issue Oct 10, 2023
Fixes #8754

* `AbstractIntegrationMessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Date expirationDate)`

**Cherry-pick to `6.1.x` & `6.0.x`**

(cherry picked from commit 75fcdda)
artembilan pushed a commit that referenced this issue Oct 10, 2023
Fixes #8754

* `AbstractIntegrationMessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Long expirationDate)`
* `MessageBuilder.setExpirationDate(@nullable Date expirationDate)`

**Cherry-pick to `6.1.x` & `6.0.x`**

(cherry picked from commit 75fcdda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants